Closed Bug 1339816 Opened 3 years ago Closed 3 years ago

Update cubeb from upstream to 8977c13b

Categories

(Core :: Audio/Video: cubeb, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla54
Tracking Status
firefox53 --- fixed
firefox54 --- verified

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(2 files)

Update cubeb from upstream to 581d4bc
Rank: 15
Priority: -- → P1
Added more fixes for drift scenarios, update to 8977c13b
Summary: Update cubeb from upstream to 581d4bc → Update cubeb from upstream to 8977c13b
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/797fddcea4e0
Update cubeb from upstream to 8977c13b. r=padenot a=needmacnightlyrespin
https://hg.mozilla.org/mozilla-central/rev/797fddcea4e0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Duplicate of this bug: 1335494
Duplicate of this bug: 1329190
Duplicate of this bug: 1321714
I prepared a patch for uplift to Aurora. Here are the try runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f285640ea452a219b4cb5dc4e52d58bf4d69ab5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=db2eedd376d82699ec0d780e10f2a600450af39c

I have also tested manually in OSX and windows. I will upload the patch tomorrow and request for approval.
Approval Request Comment
[Feature/Bug causing the regression]: bug 1335494, bug 1329190, bug 1321714 and more drift issue reported in IRC

[User impact if declined]: Drift issues which can cause delay or "scratchy" mic
audio, depending on the direction and type of drift.

[Is this code covered by automated tests?]: requires manual QA (repeated gum
tests on real HW for long call ~10mins)

[Has the fix been verified in Nightly?]: Yes, this fix is landed in Nightly

[Needs manual test from QE? If yes, steps to reproduce]:  See bug 1335494 and bug 1329190

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: I have done extensive manual tests in Nightly and Aurora in addition it is landed in Nightly and no issue so far.

[String changes made/needed]: none
Attachment #8839371 - Flags: review?(padenot)
Attachment #8839371 - Flags: approval-mozilla-aurora?
Assignee: nobody → achronop
Approval Request Comment
[Feature/Bug causing the regression]: bug 1335494, bug 1329190, bug 1321714 and more drift issue reported in IRC

[User impact if declined]: Drift issues which can cause delay or "scratchy" mic
audio, depending on the direction and type of drift.

[Is this code covered by automated tests?]: requires manual QA (repeated gum
tests on real HW for long call ~10mins)

[Has the fix been verified in Nightly?]: Yes, this fix is landed in Nightly

[Needs manual test from QE? If yes, steps to reproduce]:  See bug 1335494 and bug 1329190

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: I have done extensive manual tests in Nightly and Aurora in addition it is landed in Nightly and no issue so far.

[String changes made/needed]: none
Attachment #8839372 - Flags: review?(padenot)
Attachment #8839372 - Flags: approval-mozilla-aurora?
Attachment #8839372 - Attachment description: audiounit-drift-fix → Bug 1339816 - Part 2: Uplift cubeb audiounit drift fix. r?padenot a=?
Attachment #8839372 - Attachment is patch: true
Attachment #8839371 - Flags: review?(padenot) → review+
Attachment #8839372 - Flags: review?(padenot) → review+
Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(brindusa.tot)
Verified on Mac OS X 10.10 with FF Nighlty 54.0a1(2017-02-23) and I can confirm the fix. I used the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1335494#c0.
Status: RESOLVED → VERIFIED
Flags: needinfo?(brindusa.tot)
Comment on attachment 8839371 [details] [diff] [review]
Bug 1339816 - Part 1: Uplift cubeb wasapi drift fix and passthrough resampler. r?padenot a=?

Fix audio issue by updating cubeb and was verified. Aurora53+.
Attachment #8839371 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8839372 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Alex Chronopoulos [:achronop] from comment #16)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/
> 2d1a7803246bcd64518df53db07108b9da97d848
> https://hg.mozilla.org/releases/mozilla-aurora/rev/
> 1c202d2bb24197c9f31d96998477f485acc85be4

setting flags
Depends on: 1475431
You need to log in before you can comment on or make changes to this bug.