1339816 - Update cubeb from upstream to 8977c13b

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Alex Chronopoulos [:achronop]]

Update cubeb from upstream to 581d4bc

Comment 1

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c788d4760d7

Comment 2

[Alex Chronopoulos [:achronop]]

Added more fixes for drift scenarios, update to 8977c13b

Comment 3

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9416a107fa60f31c745acf7821b52cd5a8ef8e98
Bug 1339816 - Update cubeb from upstream to 8977c13b. r=padenot

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/797fddcea4e0
Update cubeb from upstream to 8977c13b. r=padenot a=needmacnightlyrespin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/797fddcea4e0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9416a107fa60

Comment 10

[Alex Chronopoulos [:achronop]]

I prepared a patch for uplift to Aurora. Here are the try runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f285640ea452a219b4cb5dc4e52d58bf4d69ab5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=db2eedd376d82699ec0d780e10f2a600450af39c

I have also tested manually in OSX and windows. I will upload the patch tomorrow and request for approval.

Comment 11

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1339816 - Part 1: Uplift cubeb wasapi drift fix and passthrough resampler. r?padenot a=?

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335494, bug 1329190, bug 1321714 and more drift issue reported in IRC

[User impact if declined]: Drift issues which can cause delay or "scratchy" mic
audio, depending on the direction and type of drift.

[Is this code covered by automated tests?]: requires manual QA (repeated gum
tests on real HW for long call ~10mins)

[Has the fix been verified in Nightly?]: Yes, this fix is landed in Nightly

[Needs manual test from QE? If yes, steps to reproduce]:  See bug 1335494 and bug 1329190

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: I have done extensive manual tests in Nightly and Aurora in addition it is landed in Nightly and no issue so far.

[String changes made/needed]: none

Comment 12

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1339816 - Part 2: Uplift cubeb audiounit drift fix. r?padenot a=?

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335494, bug 1329190, bug 1321714 and more drift issue reported in IRC

[User impact if declined]: Drift issues which can cause delay or "scratchy" mic
audio, depending on the direction and type of drift.

[Is this code covered by automated tests?]: requires manual QA (repeated gum
tests on real HW for long call ~10mins)

[Has the fix been verified in Nightly?]: Yes, this fix is landed in Nightly

[Needs manual test from QE? If yes, steps to reproduce]:  See bug 1335494 and bug 1329190

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: I have done extensive manual tests in Nightly and Aurora in addition it is landed in Nightly and no issue so far.

[String changes made/needed]: none

Comment 13

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 14

[ovidiu boca[:Ovidiu]]

Verified on Mac OS X 10.10 with FF Nighlty 54.0a1(2017-02-23) and I can confirm the fix. I used the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1335494#c0.

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8839371 [details] [diff] [review]
Bug 1339816 - Part 1: Uplift cubeb wasapi drift fix and passthrough resampler. r?padenot a=?

Fix audio issue by updating cubeb and was verified. Aurora53+.

Comment 16

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d1a7803246bcd64518df53db07108b9da97d848
https://hg.mozilla.org/releases/mozilla-aurora/rev/1c202d2bb24197c9f31d96998477f485acc85be4

Comment 17

[Carsten Book [:Tomcat]]

(In reply to Alex Chronopoulos [:achronop] from comment #16)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/
> 2d1a7803246bcd64518df53db07108b9da97d848
> https://hg.mozilla.org/releases/mozilla-aurora/rev/
> 1c202d2bb24197c9f31d96998477f485acc85be4

setting flags