1339832 - Buildbot specific changes to enable mozilla-esr52

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect, P1)

Description

[Rail Aliiev [:rail]]

* Configs
** new branch in config.py (firefox+tb)
** tb release configs
* tools
* new balrog rules to accommodate both esr45 and esr52
...

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Is this bug going to be used for Taskcluster changes as well?

Comment 2

[Rail Aliiev [:rail]]

Hmm, I don't think we are going to use TC for ESR52 yet. Did you have something in mind?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

We have, for example, Taskcluster-scheduled Android jobs on 52 that'll need to be turned off.

Comment 4

[Rail Aliiev [:rail]]

Hmm, for some reason I thought we turned on Tc in 53... In the worst case scenario we can turn them off after we land the BB config changes.

Comment 5

[Rail Aliiev [:rail]]

Attachment: Bug 1339832 - mozilla-esr52 specific tools changes

* Copied esr45 patcher configs so we can generate partials against esr45
  * added empty update verify files
  * removed esr38 related files
  * some other esr52 specific changes

Review commit: https://reviewboard.mozilla.org/r/114170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114170/

Comment 6

[Rail Aliiev [:rail]]

Attachment: Bug 1339832 - Buildbot specific changes to enable mozilla-esr52

* add Thunderbird release config and l10n files
  * disable SHA1 repacks on beta and release
  * disable bouncer aliases in esr45
  * kill unused "partnersRepoPath" variable
  * cargo cult of some config.py variables

Review commit: https://reviewboard.mozilla.org/r/114174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114174/

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8839601 [details]
Bug 1339832 - mozilla-esr52 specific tools changes

https://reviewboard.mozilla.org/r/114170/#review116128

looks good. one in line question.

::: lib/python/util/fabric/actions.py:242
(Diff revision 1)
>          run('ln -s %(bbconfigs_dir)s/Makefile.master %(basedir)s/Makefile' %
>              master)
>      print OK, "updated Makefile symlink in %(hostname)s:%(basedir)s" % master
>  
>  
> -def action_add_esr45_symlinks(master):
> +def action_add_esr52_symlinks(master):

won't we need this for esr45 until esr45 is dead?

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8839604 [details]
Bug 1339832 - Buildbot specific changes to enable mozilla-esr52

https://reviewboard.mozilla.org/r/114174/#review116136

::: mozilla/config.py:2640
(Diff revision 1)
> +    "firefox": "net-mozaws-prod-delivery-firefox",
> +}
> +BRANCHES['mozilla-esr52']['release_platforms'] = ("linux", "linux64", "win32", "win64", "macosx64")
> +BRANCHES['mozilla-esr52']['l10n_release_platforms'] = ("linux", "linux64", "win32", "win64", "macosx64")
> +BRANCHES['mozilla-esr52']['updates_builder_enabled'] = True
> +BRANCHES['mozilla-esr52']['update_verify_enabled'] = True

if 52.0esr has no updates to test? do we want to add updates_builder_enabled and update_verify_enabled?

::: mozilla/config.py:2804
(Diff revision 1)
>      if 'macosx64-st-an-debug' in branch['platforms']:
>          del branch['platforms']['macosx64-st-an-debug']
>  
>  # Only test pretty names on train branches, not m-c or project branches.
>  for branch in ("mozilla-aurora", "mozilla-beta", "mozilla-release",
> -               "mozilla-esr45"):
> +               "mozilla-esr52"):

do we want to keep esr45 here until we stop doing releases for it?

::: mozilla/release-fennec-mozilla-beta.py
(Diff revision 1)
>  releaseConfig['S3Bucket']            = 'net-mozaws-prod-delivery-archive'
>  releaseConfig['ausServerUrl']        = 'https://aus4.mozilla.org'
>  
>  # Partner repack configuration
>  releaseConfig['doPartnerRepacks']       = False
> -releaseConfig['partnersRepoPath']       = 'build/partner-repacks'

outside esr cleanup?

::: mozilla/release-thunderbird-comm-esr52.py:135
(Diff revision 1)
>  releaseConfig['releaseChannel']        = 'release'
>  releaseConfig['updateChannels'] = {
>      # ruleId needs to be updated with the ID from AUS
>      "release": {
>          "versionRegex": r"^.*$",
> -        "ruleId": 332,
> +        "ruleId": "thunderbird-esr52",

\o/ aliases

::: mozilla/thunderbird_config.py:793
(Diff revision 1)
>  BRANCHES['comm-esr45']['file_update_on_closed_tree'] = False
>  
> +######## comm-esr52
> +BRANCHES['comm-esr52']['repo_path'] = 'releases/comm-esr52'
> +BRANCHES['comm-esr52']['moz_repo_path'] = 'releases/mozilla-esr52'
> +BRANCHES['comm-esr52']['update_channel'] = 'nightly-esr52'

weird channel name but I guess this is a tb thing

::: mozilla/thunderbird_config.py:814
(Diff revision 1)
> +BRANCHES['comm-esr52']['enUS_binaryURL'] = \
> +    GLOBAL_VARS['download_base_url'] + '/nightly/latest-comm-esr52'
> +BRANCHES['comm-esr52']['localesURL'] = \
> +    '%s/build/buildbot-configs/raw-file/production/mozilla/l10n/all-locales.comm-esr52' % (GLOBAL_VARS['hgurl'])
> +BRANCHES['comm-esr52']['enable_nightly'] = True
> +BRANCHES['comm-esr52']['updates_enabled'] = True

same question here re: updates on first 52.0 release

::: setup-master.py
(Diff revision 1)
>                  c.globs.append('staging_release-*-*.py')
>                  # release-*.py -> staging_release-*.py symlinks
>                  c.local_links.extend(
> -                    [('staging_release-firefox-mozilla-%s.py' % v,
> -                      'release-firefox-mozilla-%s.py' % v)
> -                     for v in ['beta', 'release', 'esr45']

hm, why are we removing all of this? Looks like it affects beta and release too.

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8839604 [details]
Bug 1339832 - Buildbot specific changes to enable mozilla-esr52

https://reviewboard.mozilla.org/r/114174/#review116136

> if 52.0esr has no updates to test? do we want to add updates_builder_enabled and update_verify_enabled?

We will be generating updates against 45.x.x ESR, otherwise automation would go nuts. :)

> do we want to keep esr45 here until we stop doing releases for it?

I wouldn't worry about it at this point.

> outside esr cleanup?

this is unrelated to esr, but I couldn't stand the temptation :)

> weird channel name but I guess this is a tb thing

this is one of the cargo cult variables. :) Not sure how it may affect automation, this is why it's here.

> same question here re: updates on first 52.0 release

We will be generating partials, update verify, etc, but we won't publish the updates for reals to esr users < 52.

> hm, why are we removing all of this? Looks like it affects beta and release too.

No more release configs! We stopped using them after we switched to release promotion.

Comment 10

[Rail Aliiev [:rail]]

(In reply to Jordan Lund (:jlund) from comment #7)
 > > -def action_add_esr45_symlinks(master):
> > +def action_add_esr52_symlinks(master):
> 
> won't we need this for esr45 until esr45 is dead?

Nope, these are one off commands that I have already run :P

Comment 11

[Jordan Lund (:jlund)]

Comment on attachment 8839604 [details]
Bug 1339832 - Buildbot specific changes to enable mozilla-esr52

https://reviewboard.mozilla.org/r/114174/#review116170

Comment 12

[Jordan Lund (:jlund)]

thanks for the explanations

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 8839601 [details]
Bug 1339832 - mozilla-esr52 specific tools changes

https://hg.mozilla.org/build/tools/rev/8e9a79852606f4bb28d3f23827c6a0972af4fe87

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 8839604 [details]
Bug 1339832 - Buildbot specific changes to enable mozilla-esr52

https://hg.mozilla.org/build/buildbot-configs/rev/c0795c1164baec3e2f4671bcd654ca74ad98b8b7

Comment 15

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/c0795c1164ba