1339893 - drop down filter persistance shows empty page if no Rules exist for the saved product/channel combination

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[[e-mail] (:bhearsum)]

This is an extreme edge case (we rarely drop a product or channel), but I happened to notice in my local development environment that the drop down filter had nothing selected when I loaded the Rules page this morning.

Probably we just need to check that the saved value is still valid before setting the selected value.

Comment 1

[[e-mail] (:bhearsum)]

Relevant code is probably https://github.com/mozilla/balrog/blob/a2f13d36ae7d1b1131a633ffe6b9d61c9c911fcd/ui/app/js/controllers/rules_controller.js#L59

Comment 2

[Artem Konovalov]

Let me give it a shot.

Comment 3

[Durodola Damilola]

Okay. you can have it.

Comment 4

[Obinna Okwuolisa]

I(In reply to Ben Hearsum (:bhearsum) from comment #0)
> This is an extreme edge case (we rarely drop a product or channel), but I
> happened to notice in my local development environment that the drop down
> filter had nothing selected when I loaded the Rules page this morning.
> 
> Probably we just need to check that the saved value is still valid before
> setting the selected value.

Hello, Ben. I can't replicate the bug on my local development environment. Can please give more details about the bug?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Obinna Okwuolisa from comment #4)
> I(In reply to Ben Hearsum (:bhearsum) from comment #0)
> > This is an extreme edge case (we rarely drop a product or channel), but I
> > happened to notice in my local development environment that the drop down
> > filter had nothing selected when I loaded the Rules page this morning.
> > 
> > Probably we just need to check that the saved value is still valid before
> > setting the selected value.
> 
> Hello, Ben. I can't replicate the bug on my local development environment.
> Can please give more details about the bug?

Sure. Try this:
1) Start the development environment
2) Browse to http://localhost:8080/rules and change the Product/Channel filter to "Firefox,bad-rail".
3) Delete the first rule in the list.
4) Reload the page

You should see that the Product/Channel filter has nothing selected, and that only one Rule is present on the page. The expected result here is that if the cached filter doesn't match one of the options, "All rules" is used as the filter instead, which will show a lot more Rules.

Does that make sense?

Comment 6

[Obinna Okwuolisa]

(In reply to Ben Hearsum (:bhearsum) from comment #5)
> (In reply to Obinna Okwuolisa from comment #4)
> > I(In reply to Ben Hearsum (:bhearsum) from comment #0)
> > > This is an extreme edge case (we rarely drop a product or channel), but I
> > > happened to notice in my local development environment that the drop down
> > > filter had nothing selected when I loaded the Rules page this morning.
> > > 
> > > Probably we just need to check that the saved value is still valid before
> > > setting the selected value.
> > 
> > Hello, Ben. I can't replicate the bug on my local development environment.
> > Can please give more details about the bug?
> 
> Sure. Try this:
> 1) Start the development environment
> 2) Browse to http://localhost:8080/rules and change the Product/Channel
> filter to "Firefox,bad-rail".
> 3) Delete the first rule in the list.
> 4) Reload the page
> 
> You should see that the Product/Channel filter has nothing selected, and
> that only one Rule is present on the page. The expected result here is that
> if the cached filter doesn't match one of the options, "All rules" is used
> as the filter instead, which will show a lot more Rules.
> 
> Does that make sense?

Yes it does. I'll look at it

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/d869d9a893bc69a1492b41273f9d3da75f57d15a
Bug 1339893: show "All rules" if no value is selected on the product/channel filter (#391). r=bhearsum

Comment 8

[[e-mail] (:bhearsum)]

This is in production, nice work Obinna!