Closed Bug 1339947 Opened 4 years ago Closed 4 years ago

ArrayData lookups in mscom registration code need to take inheritance into account

Categories

(Core :: IPC, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: aes+)

Attachments

(1 file)

Suppose we have ArrayData defined for IAccessible.

Since IAccessible2 inherits from IAccessible, an incoming IAccessible2 call that invokes IAccessible methods may need to access IAccessible's  ArrayData.

Simply comparing IIDs will fail here; we actually need to look at the inheritance hierarchy to determine whether we should check ArrayData belonging to different interfaces.

We use the vtable index of the method call as a hint to help speed this up.
Comment on attachment 8837800 [details]
Bug 1339947: Make mscom ArrayData lookup respect interface inheritance;

https://reviewboard.mozilla.org/r/112802/#review115036
Attachment #8837800 - Flags: review?(jmathies) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f62e9d267ac5
Make mscom ArrayData lookup respect interface inheritance; r=jimm
https://hg.mozilla.org/mozilla-central/rev/f62e9d267ac5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Depends on: 1341082
You need to log in before you can comment on or make changes to this bug.