1339966 - Add a pref to disable content styling for <select> and <option>

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

We have had a fair amount of regressions noted by the landing of bug 910022, and we don't know of a viable route to fixing bug 1338283.

In the meantime, and for future planning safety, we should land a pref that will allow us to disable this feature. As part of this initial landing, we should disable the feature on Linux due to bug 1338283.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1339966 - Add a pref to disable content styling for <select> and <option>.

Review commit: https://reviewboard.mozilla.org/r/112834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112834/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8837835 [details]
Bug 1339966 - Add a pref to disable content styling for <select> and <option>.

https://reviewboard.mozilla.org/r/112834/#review114412

Looks good. Don't forget to update your test to set the pref to true for the tests that test the colours, otherwise those will orange out for Linux.

::: modules/libpref/init/all.js:1196
(Diff revision 1)
> +// Allow for webpages to provide custom styling for <select>
> +// popups. Disabled on Linux due to bug 1338283.
> +#ifdef XP_LINUX
> +pref("dom.forms.select.customstyling", false);
> +#else
> +pref("dom.forms.select.customstyling", true);
> +#endif

Should we maybe put this near the dom.select_popup_in_parent.enabled pref, since they're so related?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8837835 [details]
Bug 1339966 - Add a pref to disable content styling for <select> and <option>.

https://reviewboard.mozilla.org/r/112834/#review114412

> Should we maybe put this near the dom.select_popup_in_parent.enabled pref, since they're so related?

That pref is next to a comment that mentions it is there for testing purposes only. I'll move it here so that it is with the other select prefs, which are also only here for testing/compat purposes anyways.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8837835 [details]
Bug 1339966 - Add a pref to disable content styling for <select> and <option>.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112834/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35ddc6aaed8b
Add a pref to disable content styling for <select> and <option>. r=mconley

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35ddc6aaed8b