13400 - should cache string bundles

Status: VERIFIED WONTFIX

(MailNews Core :: Composition, defect, P3)

Description

[David :Bienvenu]

I believe we can get a performance win by caching string bundles instead of
loading the string resource file every time we need a string.

These are the two calls that create string bundles that could cache them. I've
fixed the leak of the string bundles.

nsMsgComposeStringBundle.cpp(64):    res =
sBundleService->CreateBundle(propertyURL, locale, &sBundle);
nsMsgComposeStringBundle.cpp(80):    res = sBundleService->CreateBundle(url,
locale, &sBundle);

Comment 1

[leger]

Putting on [Perf] radar.

Comment 2

[lchiang]

(target milestone is M11 or M12 - add to mail beta tracking bug)

Comment 3

[Jean-Francois Ducarroz]

Reassign to Rich as he implemented StringBundle in msgCompose...

Comment 4

[rhp (gone)]

I have two bugs related to cacheing of string bundles. This one and one for
libmime. Reworking this code to cache the string bundle wouldn't really give us
any sort of performance win because the only time these calls are made are
during error conditions. (i.e. display error to user). The libmime issues are
valid since they are called much more frequently, but this would be a lot of
work for little gain, so I am marking WONTFIX.

- rhp

Comment 5

[lchiang]

Ok, I'll verify as won't fix then.