Closed
Bug 1340033
Opened 8 years ago
Closed 8 years ago
stylo: Remove dependency from StyleAnimationValue.h to ServoBindings.h
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
StyleAnimationValue.h is a header which is included too widely... It isn't worth recompiling so many files for a change to ServoBindings.h.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8837925 [details]
Bug 1340033 - Remove dependency from StyleAnimationValue.h to ServoBindings.h.
https://reviewboard.mozilla.org/r/112918/#review114410
Thanks for doing this!
I think this will conflict the patch for bug 1337229.
You will have to move AnimationValue::operator== as well, or Shing has to. ;-)
Attachment #8837925 -
Flags: review?(hikezoe) → review+
|
Assignee | |
Comment 3•8 years ago
|
||
I pinged Shing but he doesn't reply me... Let me land it and ni? him in bug 1337229.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60efb5fce01e
Remove dependency from StyleAnimationValue.h to ServoBindings.h. r=hiro
|
|
Assignee | |
Comment 5•8 years ago
|
||
(I probably should do a build-only try run first... This kind of changes usually lead to build failures in other platforms given that msvc is the most lenient compiler for inline specifier.)
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•