Closed Bug 1340086 Opened 6 years ago Closed 6 years ago

Remove uses of AnimationsPaused() since it is always false after bug 1316330

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

Attachments

(1 file, 1 obsolete file)

patch, v2.
19.33 KB, patch
jessica
: review+
Details | Diff | Splinter Review 
Follow-up to bug 1316330.

Bug 1316330 drops the use of suppressing eAnimationsOnly, so I think we can remove AnimationsPaused().
Priority: -- → P2
Assignee: nobody → jjong
Attached patch patch, v1. (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 8838446 [details] [diff] [review]
patch, v1.

Hi Blake, may I have your review on this? Thanks.

        Attachment #8838446 -
        Flags: review?(mrbkap)

    
    

    
  
Comment on attachment 8838446 [details] [diff] [review]
patch, v1.

Review of attachment 8838446 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: dom/base/nsDocument.cpp
@@ +9679,5 @@
>  
>  void
> +nsDocument::UnsuppressEventHandlingAndFireEvents(bool aFireEvents)
> +{
> +  nsTArray<nsCOMPtr<nsIDocument> > documents;

Might as well remove the now-unnecessary space between the >s (nsTArray<nsCOMPtr<nsIDocument>>).

        Attachment #8838446 -
        Flags: review?(mrbkap) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, v2.
        — 
          — Splinter Review
      

    


  
Addressed nit in comment 3, carrying r+.

        Attachment #8838446 -
        Attachment is obsolete: true

        Attachment #8839835 -
        Flags: review+

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20c29c6769fe
Remove uses of AnimationsPaused() since it is always false after bug 1316330. r=mrbkap
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/20c29c6769fe
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox54:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.