Closed
Bug 1340086
Opened 6 years ago
Closed 6 years ago
Remove uses of AnimationsPaused() since it is always false after bug 1316330
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
Attachments
(1 file, 1 obsolete file)
19.33 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
Follow-up to bug 1316330. Bug 1316330 drops the use of suppressing eAnimationsOnly, so I think we can remove AnimationsPaused().
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jjong
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Comment on attachment 8838446 [details] [diff] [review] patch, v1. Hi Blake, may I have your review on this? Thanks.
Attachment #8838446 -
Flags: review?(mrbkap)
Comment 3•6 years ago
|
||
Comment on attachment 8838446 [details] [diff] [review] patch, v1. Review of attachment 8838446 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: dom/base/nsDocument.cpp @@ +9679,5 @@ > > void > +nsDocument::UnsuppressEventHandlingAndFireEvents(bool aFireEvents) > +{ > + nsTArray<nsCOMPtr<nsIDocument> > documents; Might as well remove the now-unnecessary space between the >s (nsTArray<nsCOMPtr<nsIDocument>>).
Attachment #8838446 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 4•6 years ago
|
||
Addressed nit in comment 3, carrying r+.
Attachment #8838446 -
Attachment is obsolete: true
Attachment #8839835 -
Flags: review+
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8368750808e0a6a666618e18a02f3d0794cd7a9&group_state=expanded
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/20c29c6769fe Remove uses of AnimationsPaused() since it is always false after bug 1316330. r=mrbkap
Keywords: checkin-needed
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/20c29c6769fe
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•