No updates found after closing the Add-ons Manager tab which displays the interactive update pop-up

NEW
Unassigned

Status

()

Toolkit
Add-ons Manager
P5
normal
10 months ago
3 months ago

People

(Reporter: Vasilica Mihasca, QA [away for an extended period of time - please needinfo addonsqa@softvision.ro], Unassigned, NeedInfo)

Tracking

(Blocks: 1 bug)

54 Branch
Points:
---

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53 unaffected, firefox54 affected)

Details

(Whiteboard: triaged)

[Affected versions]:
Firefox 54.0a1 (2017-02-15)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit
Mac Os X 10.12.1


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Create xpinstall.signatures.dev-root and set it to true.
4.Change extensions.update.url to point to dev server.
5.Install the first version of the following webextension: https://addons-dev.allizom.org/en-US/firefox/addon/webext111/versions/
6.Go to about:addons -> Extensions and check for updates. (do not upgrade the webextension)
7.Close Add-ons Manager tab.
8.Navigate again to about:add-ons -> Extensions and check for updates.


[Expected Results]:
The updates are found and permissions pop-up is successfully displayed requesting the user upgrade approval.


[Actual Results]:
- There are no updates found. 
- See screencast: https://www.screencast.com/t/ZdTqZo8SPUvA
- No errors are thrown in Browser Console.
- The updates are successfully found after a browser restart.

Comment 1

10 months ago
In this scenario we never notice that the tab has been closed so we don't cancel the install and the fact that there is a pending install means subsequent update checks skip over this extension.
Florian, should I expect to see a popup's eventCallback called with the "dismissed" topic if the popup's tab is closed while it is visible?
Flags: needinfo?(florian)
(In reply to Andrew Swan [:aswan] from comment #1)
> In this scenario we never notice that the tab has been closed so we don't
> cancel the install and the fact that there is a pending install means
> subsequent update checks skip over this extension.
> Florian, should I expect to see a popup's eventCallback called with the
> "dismissed" topic if the popup's tab is closed while it is visible?

There's no eventCallback call in that case currently. I don't think 'dismissed' would be the right event, but I think 'removed' would make sense (as we fire 'removed' events when notifications are removed due to location changes, or tabs being torn off).

PopupNotifications doesn't have any event listener to handle the TabClose case right now, because the notifications are stored in a WeakMap, which doesn't require explicit cleanup.
Flags: needinfo?(florian)

Updated

10 months ago
Priority: -- → P3
Whiteboard: triaged

Comment 3

8 months ago
file bug under area that could resolve :) than then will fix this or not based on listener existing
Flags: needinfo?(aswan)

Comment 4

8 months ago
(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> PopupNotifications doesn't have any event listener to handle the TabClose
> case right now, because the notifications are stored in a WeakMap, which
> doesn't require explicit cleanup.

Finally getting back to this.  I didn't fully grok that last comment, but is the solution for the code that creates the notification to also add a listener for TabClose rather than expecting to get it forwarded through PopupNotifications?
Flags: needinfo?(aswan) → needinfo?(florian)

Updated

3 months ago
Blocks: 1401643
No longer blocks: 1308292

Updated

3 months ago
Priority: P3 → P5
You need to log in before you can comment on or make changes to this bug.