Closed Bug 1340144 Opened 8 years ago Closed 8 years ago

[clang-format] Incorrect alignment of the function declaration when using template

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox54 --- affected

People

(Reporter: Sylvestre, Assigned: andi)

References

Details

template<typename T> // Templates on own line. static int // Return type on own line for top-level functions. MyFunction(int a) is converted by clang-format to template<typename T> // Templates on own line. static int // Return type on own line for top-level functions. MyFunction(int a) which is incorrect cf https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Methods
though a comment on this topic, this bug appears only when we have a comment on the return type declaration line.
moved upstream https://bugs.llvm.org/show_bug.cgi?id=32016
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
No need to close it actually
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
A patch for this issue has been submitted to upstream: https://reviews.llvm.org/D30646
Assignee: nobody → bpostelnicu
This has been fixed upstream: https://reviews.llvm.org/rL285178
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.