1340145 - HTML-comments shouldn't be enabled for module-code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Test case:
---
print(JSON.stringify(Reflect.parse("a <!-- b", {target: "module", loc: false}), null, " "))
---

HTML-comments (https://tc39.github.io/ecma262/#sec-html-like-comments) shouldn't enabled when the parse goal is |Module|.


Expected parse tree:
---
{
 "loc": null,
 "type": "Program",
 "body": [
  {
   "loc": null,
   "type": "ExpressionStatement",
   "expression": {
    "loc": null,
    "type": "BinaryExpression",
    "operator": "<",
    "left": {
     "loc": null,
     "type": "Identifier",
     "name": "a"
    },
    "right": {
     "loc": null,
     "type": "UnaryExpression",
     "operator": "!",
     "argument": {
      "loc": null,
      "type": "UpdateExpression",
      "operator": "--",
      "argument": {
       "loc": null,
       "type": "Identifier",
       "name": "b"
      },
      "prefix": true
     },
     "prefix": true
    }
   }
  }
 ]
}
---

Actual parse tree:
---
{
 "loc": null,
 "type": "Program",
 "body": [
  {
   "loc": null,
   "type": "ExpressionStatement",
   "expression": {
    "loc": null,
    "type": "Identifier",
    "name": "a"
   }
  }
 ]
}
---

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1340145-module-comments

Patch to make accepting HTML comments a compiler option.

Comment 2

[André Bargull [:anba]]

Comment on attachment 8839477 [details] [diff] [review]
bug1340145-module-comments

Review of attachment 8839477 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to disallow the html end-comment marker `-->` in https://dxr.mozilla.org/mozilla-central/rev/d0462b0948e0b1147dcce615bddcc46379bdadb2/js/src/frontend/TokenStream.cpp#1867-1874

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1340145-module-comments v2

Fixed.

Comment 4

[André Bargull [:anba]]

Comment on attachment 8839500 [details] [diff] [review]
bug1340145-module-comments v2

Review of attachment 8839500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a4c2e34e6e
Don't allow HTML comments in module scripts r=anba

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c7a4c2e34e6e