Closed Bug 1340172 Opened 3 years ago Closed 3 years ago

Enable EME only on nightly

Categories

(Firefox for Android :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: bwu, Assigned: JamesCheng)

References

Details

Attachments

(2 files)

Per discussing in an EME mail thread, before having a UI (bug 1338950), we should disable EME.
(In reply to Blake Wu [:bwu][:blakewu] from comment #0)
> Per discussing in an EME mail thread, before having a UI (bug 1338950), we
The correct UI bug is bug 1340169.
See Also: → 1340169
James,
Please help disable it and need to uplift it to 53 as well.
Thanks!
Assignee: nobody → jacheng
Hi Chris,
This patch is for uplifting to Aurora.
Since pref "media.eme.apiVisible" had been removed, I should create this patch for uplifting.
Please review it and I will do the uplifting later.

Thank you.
Attachment #8838367 - Flags: review?(cpearce)
Summary: Disable EME on Fennec → Enable EME only on nightly
Comment on attachment 8838365 [details]
Bug 1340172 - Disable EME on Fennec(Only pref on for Nightly).

https://reviewboard.mozilla.org/r/113300/#review115784
Attachment #8838365 - Flags: review?(cpearce) → review+
Comment on attachment 8838367 [details] [diff] [review]
(Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Review of attachment 8838367 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for slow review, this got lost in my email.
Attachment #8838367 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3aead1e9d17
Disable EME on Fennec(Only pref on for Nightly). r=cpearce
Comment on attachment 8838367 [details] [diff] [review]
(Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Approval Request Comment
[Feature/Bug causing the regression]:1340172
[User impact if declined]:User can view DRM content without poping-up a dialog like desktop browser, that will cause some legal concern.
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]:Keep this in nightly and disable it in aurora only.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:No
[Is the change risky?]:No
[Why is the change risky/not risky?]:Only disable the EME API set.
[String changes made/needed]:No
Attachment #8838367 - Flags: approval-mozilla-aurora?
Thanks for Chris' review. will enable it when bug 1340169  landed.
https://hg.mozilla.org/mozilla-central/rev/e3aead1e9d17
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8838367 [details] [diff] [review]
(Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Disable EME on 53. Aurora53+.
Attachment #8838367 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.