Closed
Bug 1340172
Opened 7 years ago
Closed 7 years ago
Enable EME only on nightly
Categories
(Firefox for Android Graveyard :: Audio/Video, defect)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox53 fixed, firefox54 fixed)
RESOLVED
FIXED
Firefox 54
People
(Reporter: bwu, Assigned: JamesCheng)
References
Details
Attachments
(2 files)
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
912 bytes,
patch
|
cpearce
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Per discussing in an EME mail thread, before having a UI (bug 1338950), we should disable EME.
Reporter | ||
Comment 1•7 years ago
|
||
(In reply to Blake Wu [:bwu][:blakewu] from comment #0) > Per discussing in an EME mail thread, before having a UI (bug 1338950), we The correct UI bug is bug 1340169.
See Also: → 1340169
Reporter | ||
Comment 2•7 years ago
|
||
James, Please help disable it and need to uplift it to 53 as well. Thanks!
Assignee: nobody → jacheng
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Hi Chris, This patch is for uplifting to Aurora. Since pref "media.eme.apiVisible" had been removed, I should create this patch for uplifting. Please review it and I will do the uplifting later. Thank you.
Attachment #8838367 -
Flags: review?(cpearce)
Comment hidden (mozreview-request) |
Reporter | ||
Updated•7 years ago
|
Summary: Disable EME on Fennec → Enable EME only on nightly
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8838365 [details] Bug 1340172 - Disable EME on Fennec(Only pref on for Nightly). https://reviewboard.mozilla.org/r/113300/#review115784
Attachment #8838365 -
Flags: review?(cpearce) → review+
Comment 7•7 years ago
|
||
Comment on attachment 8838367 [details] [diff] [review] (Aurora)Bug-1340172-Disable-EME-on-Fennec.patch Review of attachment 8838367 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for slow review, this got lost in my email.
Attachment #8838367 -
Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3aead1e9d17 Disable EME on Fennec(Only pref on for Nightly). r=cpearce
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 8838367 [details] [diff] [review] (Aurora)Bug-1340172-Disable-EME-on-Fennec.patch Approval Request Comment [Feature/Bug causing the regression]:1340172 [User impact if declined]:User can view DRM content without poping-up a dialog like desktop browser, that will cause some legal concern. [Is this code covered by automated tests?]:No [Has the fix been verified in Nightly?]:Keep this in nightly and disable it in aurora only. [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]:No [Is the change risky?]:No [Why is the change risky/not risky?]:Only disable the EME API set. [String changes made/needed]:No
Attachment #8838367 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•7 years ago
|
||
Thanks for Chris' review. will enable it when bug 1340169 landed.
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3aead1e9d17
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 12•7 years ago
|
||
Comment on attachment 8838367 [details] [diff] [review] (Aurora)Bug-1340172-Disable-EME-on-Fennec.patch Disable EME on 53. Aurora53+.
Attachment #8838367 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•7 years ago
|
status-firefox53:
--- → affected
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/3383ac0e02e1
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•