1340172 - Enable EME only on nightly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Blake Wu [:bwu][:blakewu]]

Per discussing in an EME mail thread, before having a UI (bug 1338950), we should disable EME.

Comment 1

[Blake Wu [:bwu][:blakewu]]

(In reply to Blake Wu [:bwu][:blakewu] from comment #0)
> Per discussing in an EME mail thread, before having a UI (bug 1338950), we
The correct UI bug is bug 1340169.

Comment 2

[Blake Wu [:bwu][:blakewu]]

James,
Please help disable it and need to uplift it to 53 as well.
Thanks!

Comment 3

[James Cheng[:JamesCheng]]

Attachment: Bug 1340172 - Disable EME on Fennec(Only pref on for Nightly).

Review commit: https://reviewboard.mozilla.org/r/113300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113300/

Comment 4

[James Cheng[:JamesCheng]]

Attachment: (Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Hi Chris,
This patch is for uplifting to Aurora.
Since pref "media.eme.apiVisible" had been removed, I should create this patch for uplifting.
Please review it and I will do the uplifting later.

Thank you.

Comment 5

[James Cheng[:JamesCheng]]

Comment on attachment 8838365 [details]
Bug 1340172 - Disable EME on Fennec(Only pref on for Nightly).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/113300/diff/1-2/

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8838365 [details]
Bug 1340172 - Disable EME on Fennec(Only pref on for Nightly).

https://reviewboard.mozilla.org/r/113300/#review115784

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8838367 [details] [diff] [review]
(Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Review of attachment 8838367 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for slow review, this got lost in my email.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3aead1e9d17
Disable EME on Fennec(Only pref on for Nightly). r=cpearce

Comment 9

[James Cheng[:JamesCheng]]

Comment on attachment 8838367 [details] [diff] [review]
(Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Approval Request Comment
[Feature/Bug causing the regression]:1340172
[User impact if declined]:User can view DRM content without poping-up a dialog like desktop browser, that will cause some legal concern.
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]:Keep this in nightly and disable it in aurora only.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:No
[Is the change risky?]:No
[Why is the change risky/not risky?]:Only disable the EME API set.
[String changes made/needed]:No

Comment 10

[James Cheng[:JamesCheng]]

Thanks for Chris' review. will enable it when bug 1340169  landed.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e3aead1e9d17

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8838367 [details] [diff] [review]
(Aurora)Bug-1340172-Disable-EME-on-Fennec.patch

Disable EME on 53. Aurora53+.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3383ac0e02e1