Open Bug 1340224 Opened 4 years ago Updated 4 months ago

stylo: Test whether Stylo improves terrible restyle performance on cleopatra

Categories

(Core :: CSS Parsing and Computation, defect, P5)

defect

Tracking

()

Tracking Status
firefox54 --- affected
firefox57 --- wontfix

People

(Reporter: ehsan, Unassigned)

References

Details

Cleopatra is almost unusably slow if you increase the Gecko Profiler buffer size (I use 90MB for example).

I was wondering why that is today.  It seems like our restyling is extremely inefficient on this page.  For example, see this profile: https://perfht.ml/2lSZEeH.  We are spending 3.8 *seconds* restyling, in three chunks of roughly the same size.  This is easily visible if you for example try selecting a range in the timeline.  Each click has a dag of seconds to have any effect.

The profile in question from which the measurement was obtained is <https://perf-html.io/public/55385c23113278e8db31a2fee58338fdbf04bfd1/calltree/?search=topicListener&thread=1>.
Bobby, if stylo is far enough, I'm very curious to know how well it performs on this page...
Flags: needinfo?(bobbyholley)
See Also: → 1340226
See Also: → 1340228
It isn't far enough to provide a useful answer to this question. I'll add this as a dep so we can remember to measure when we're getting close to landing on nightly.
Flags: needinfo?(bobbyholley)
For anyone in the future looking at this, you may need to run the project locally, and check out the version from this date in case our implementation changes: https://github.com/devtools-html/perf.html

That top header may be re-worked.
That rework has landed. https://github.com/devtools-html/perf.html/pull/168
You'll need to check out a commit before that PR if you want to reproduce this.
Priority: -- → P3
Summary: Terrible restyle performance on cleopatra → stylo: Test whether Stylo improves terrible restyle performance on cleopatra
Priority: P3 → --
Priority: -- → P5
status-firefox57=wontfix unless someone thinks this bug should block 57
You need to log in before you can comment on or make changes to this bug.