1340277 - stylo: dynamic changes to text-overflow on elements with non-visible overflow don't work

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Testcase in URL field.

This is because we don't update the style on the scrolled-content frame.  So a special case of bug 1292609.

We don't have in-tree tests for this, at first glance, so should make sure to add some.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1340277. Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe.

Review commit: https://reviewboard.mozilla.org/r/116642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116642/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8842899 [details]
Bug 1340277.  Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe.

https://reviewboard.mozilla.org/r/116642/#review118716

Nice code/test ratio :)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8842899 [details]
Bug 1340277.  Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116642/diff/1-2/

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8842899 [details]
Bug 1340277.  Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116642/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b866630a4183
Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe.  r=emilio

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b866630a4183