The compositor thread is missing in profiles

RESOLVED FIXED in Firefox 54

Status

()

Core
Gecko Profiler
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: mstange, Assigned: njn)

Tracking

({regression})

Trunk
mozilla54
regression
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox53 unaffected, firefox54 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
This started a few days ago, I think.

STR:
 1. In a fresh Firefox profile, install the gecko profiler addon
 2. Get a profile

The resulting profile doesn't have a Compositor thread.
(Assignee)

Comment 1

6 months ago
Probably my fault :)  I'll take a look.
Assignee: nobody → n.nethercote
(Assignee)

Comment 2

6 months ago
(In reply to Nicholas Nethercote [:njn] from comment #1)
> Probably my fault :)  I'll take a look.

Actually, looks like it's something about the compositor itself. I've bisected down to this:

changeset:   342278:a5270cca9e28
parent:      342277:764e2c0ad987
parent:      341825:b9c6246f13ea
user:        Kartikaya Gupta <kgupta@mozilla.com>
date:        Fri Feb 10 13:57:53 2017 -0500
summary:     Merge m-c to graphics

I have a few more iterations to go, but I might not get to them until tomorrow.
(Assignee)

Comment 3

6 months ago
In the end it is my fault.

changeset:   341665:4a894b2316f0
user:        Nicholas Nethercote <nnethercote@mozilla.com>
date:        Wed Feb 08 12:01:41 2017 +1100
summary:     Bug 1337189 (part 16) - Move all the bools out of Sampler. r=mstange.

I haven't yet worked out the problem.
(Assignee)

Comment 4

6 months ago
Created attachment 8838519 [details] [diff] [review]
Set bools earlier in profiler_start()

They must be set before the call to MaybeSetProfiler(), which checks
gProfileThreads, and before the gTaskTracer check.

This patch fixes the failure of some threads (e.g. Compositor) to be profiled,
as well as allowing TaskTracer to start up again!
Attachment #8838519 - Flags: review?(mstange)
(Reporter)

Updated

6 months ago
Attachment #8838519 - Flags: review?(mstange) → review+
(Reporter)

Updated

6 months ago
Blocks: 1337189
(Assignee)

Comment 5

6 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/421a05b31eae5bbc0f49dbcd500da6a0da7cb2bd
Bug 1340327 - Set bools earlier in profiler_start(). r=mstange.

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/421a05b31eae
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
You need to log in before you can comment on or make changes to this bug.