Closed Bug 1340357 Opened 4 years ago Closed 4 years ago

Remove all special eslint rules in services/

Categories

(Cloud Services :: General, defect, P1)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
Tracking Status
firefox54 --- fixed

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

Running eslint over services spews lots of warnings from the "consistent-return" eslint rule. This bug is to fix those warnings and enable the rule such that future violations will be an actual error.
Let's go the whole hog :)
Summary: Enable "consistent-return" eslint rule in services/ → Remove all special eslint rules in services/
Comment on attachment 8838340 [details]
Bug 1340357 - remove all special eslint rules in services/.

https://reviewboard.mozilla.org/r/113278/#review114838

Awesome!
Attachment #8838340 - Flags: review?(eoger) → review+
Assignee: nobody → markh
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/b6118fb4d039
remove all special eslint rules in services/. r=eoger
https://hg.mozilla.org/mozilla-central/rev/b6118fb4d039
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.