Closed
Bug 1340357
Opened 8 years ago
Closed 8 years ago
Remove all special eslint rules in services/
Categories
(Cloud Services :: General, defect, P1)
Cloud Services
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
Running eslint over services spews lots of warnings from the "consistent-return" eslint rule. This bug is to fix those warnings and enable the rule such that future violations will be an actual error.
|
Assignee | |
Comment 1•8 years ago
|
||
Let's go the whole hog :)
Summary: Enable "consistent-return" eslint rule in services/ → Remove all special eslint rules in services/
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8838340 [details]
Bug 1340357 - remove all special eslint rules in services/.
https://reviewboard.mozilla.org/r/113278/#review114838
Awesome!
Attachment #8838340 -
Flags: review?(eoger) → review+
|
|
||
Updated•8 years ago
|
Assignee: nobody → markh
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/b6118fb4d039
remove all special eslint rules in services/. r=eoger
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•