Closed Bug 1340379 Opened 3 years ago Closed 3 years ago

Remove hardcoded Homebrew URL of autoconf 2.13 for macOS

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kuoe0.tw, Assigned: kuoe0.tw)

Details

Attachments

(1 file)

We can install autoconf 2.13 with `brew install autoconf@2.13` directly with the current version of Homebrew. I think it's better to install without a hardcoded command.
Comment on attachment 8838366 [details]
Bug 1340379 - Remove hardcoded Homebrew URL of autoconf 2.13 for macOS.

https://reviewboard.mozilla.org/r/113304/#review114948

If it works for you, it works for me!  If you're interested in making this _all_ better, I'd love help on https://bugzilla.mozilla.org/show_bug.cgi?id=1280165.

Thanks!
Attachment #8838366 - Flags: review?(nalexander) → review+
Assignee: nobody → kuoe0
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4b77e19251ae
Remove hardcoded Homebrew URL of autoconf 2.13 for macOS. r=nalexander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4b77e19251ae
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8838366 [details]
Bug 1340379 - Remove hardcoded Homebrew URL of autoconf 2.13 for macOS.

https://reviewboard.mozilla.org/r/113304/#review116158

::: python/mozboot/mozboot/osx.py:315
(Diff revision 1)
>              ('python', 'python'),
>              ('mercurial', 'mercurial'),
>              ('git', 'git'),
> -            ('autoconf213', HOMEBREW_AUTOCONF213),
> +            ('autoconf@2.13', 'autoconf@2.13'),
>              ('gnu-tar', 'gnu-tar'),
>              ('watchman', 'watchman',),
>              ('terminal-notifier', 'terminal-notifier')

Note that the url for autoconf was the only reason to have packages defined as tuples. Now, all of them are just of the form ('foo', 'foo'), so they might as well be replaced with one string each.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.