Closed
Bug 1340393
Opened 7 years ago
Closed 7 years ago
Remove -FS option
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
mozilla54
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 1 obsolete file)
By bug 915973, I add -FS option to support VS2013+. But after landing bug 1322703, -FS option is unnecessary.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8838376 [details] Bug 1340393 - Remove unnecessary -FS option. https://reviewboard.mozilla.org/r/113314/#review115486
Attachment #8838376 -
Flags: review?(mh+mozilla) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/e7c397118fd2 Remove unnecessary -FS option. r=glandium
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e7c397118fd2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
I did a Ctrl+C to interrupt a build, and now all my rebuilds say: 0:06.94 d:/build/msys/s/central/obj/win64fre/dom/bindings/UnifiedBindings21.cpp: fatal error C1041: cannot open program database 'd:\build\msys\s\central\obj\win64fre\dom\bindings\UnifiedBindings21.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS until I manually rm that file. Is it possible for the build system to do this cleanup for me? (I'm happy to file another bug if so.)
Depends on: 1322703
Comment 6•7 years ago
|
||
(In reply to David Major [:dmajor] from comment #5) > I did a Ctrl+C to interrupt a build, and now all my rebuilds say: > > 0:06.94 > d:/build/msys/s/central/obj/win64fre/dom/bindings/UnifiedBindings21.cpp: > fatal error C1041: cannot open program database > 'd:\build\msys\s\central\obj\win64fre\dom\bindings\UnifiedBindings21.pdb'; > if multiple CL.EXE write to the same .PDB file, please use /FS > > until I manually rm that file. > > Is it possible for the build system to do this cleanup for me? (I'm happy to > file another bug if so.) It should be, from one of the $(RM_PDB_FILE)s added in bug 1322703
Comment 7•7 years ago
|
||
This seems to have improved build times on windows: == Change summary for alert #5217 (as of February 21 2017 01:07 UTC) == Improvements: 3% build times summary windows2012-32 pgo taskcluster-c4.4xlarge 4002.58 -> 3876.73 3% build times summary windows2012-64 pgo taskcluster-c4.4xlarge 4422.38 -> 4300.46 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=5217 Hopefully that was expected (or at least not indicative of anything bad)
Comment 8•7 years ago
|
||
Had to back this out to fix Windows pgo builds after bug 1322703 got backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/be8abf34c44948dd81253137ab52fd445b09e141 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=80875701&repo=mozilla-inbound (Same issue for spidermonkey cgc and p on Windows)
Status: RESOLVED → REOPENED
Flags: needinfo?(m_kato)
Resolution: FIXED → ---
Assignee | ||
Comment 9•7 years ago
|
||
This depends on bug 1322703. When bug 1322703 is backed out, this fix should be backed out. (But SIMPLE_PROGRAM can remove this option, so I will file new bug since bug 1322703 is backed out)
Flags: needinfo?(m_kato)
Merged backout: https://hg.mozilla.org/mozilla-central/rev/be8abf34c449
Assignee | ||
Updated•7 years ago
|
Attachment #8838376 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8844374 [details] Bug 1340393 - Remove -FS option on SIMPLE_PROGRAM. https://reviewboard.mozilla.org/r/117860/#review119900
Attachment #8844374 -
Flags: review?(mh+mozilla) → review+
Comment 13•7 years ago
|
||
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/4dcf2939c5f6 Remove -FS option on SIMPLE_PROGRAM. r=glandium
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4dcf2939c5f6
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Updated•7 years ago
|
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•