1340393 - Remove -FS option

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

By bug 915973, I add -FS option to support VS2013+.  But after landing bug 1322703, -FS option is unnecessary.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1340393 - Remove unnecessary -FS option.

Although I add -FS option to support VS2013+ by bug 915973, after landing bug 1322703, -FS option is unnecessary now.

Review commit: https://reviewboard.mozilla.org/r/113314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113314/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8838376 [details]
Bug 1340393 - Remove unnecessary -FS option.

https://reviewboard.mozilla.org/r/113314/#review115486

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c397118fd2
Remove unnecessary -FS option. r=glandium

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e7c397118fd2

Comment 5

[(Away)]

I did a Ctrl+C to interrupt a build, and now all my rebuilds say:

 0:06.94 d:/build/msys/s/central/obj/win64fre/dom/bindings/UnifiedBindings21.cpp: fatal error C1041: cannot open program database 'd:\build\msys\s\central\obj\win64fre\dom\bindings\UnifiedBindings21.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS

until I manually rm that file.

Is it possible for the build system to do this cleanup for me? (I'm happy to file another bug if so.)

Comment 6

[Mike Hommey [:glandium]]

(In reply to David Major [:dmajor] from comment #5)
> I did a Ctrl+C to interrupt a build, and now all my rebuilds say:
> 
>  0:06.94
> d:/build/msys/s/central/obj/win64fre/dom/bindings/UnifiedBindings21.cpp:
> fatal error C1041: cannot open program database
> 'd:\build\msys\s\central\obj\win64fre\dom\bindings\UnifiedBindings21.pdb';
> if multiple CL.EXE write to the same .PDB file, please use /FS
> 
> until I manually rm that file.
> 
> Is it possible for the build system to do this cleanup for me? (I'm happy to
> file another bug if so.)

It should be, from one of the $(RM_PDB_FILE)s added in bug 1322703

Comment 7

[William Lachance (:wlach)]

This seems to have improved build times on windows:

== Change summary for alert #5217 (as of February 21 2017 01:07 UTC) ==

Improvements:

  3%  build times summary windows2012-32 pgo taskcluster-c4.4xlarge     4002.58 -> 3876.73
  3%  build times summary windows2012-64 pgo taskcluster-c4.4xlarge     4422.38 -> 4300.46

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=5217

Hopefully that was expected (or at least not indicative of anything bad)

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Had to back this out to fix Windows pgo builds after bug 1322703 got backed out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/be8abf34c44948dd81253137ab52fd445b09e141

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=80875701&repo=mozilla-inbound
(Same issue for spidermonkey cgc and p on Windows)

Comment 9

[Makoto Kato [:m_kato]]

This depends on bug 1322703.  When bug 1322703 is backed out, this fix should be backed out.

(But SIMPLE_PROGRAM can remove this option, so I will file new bug since bug 1322703 is backed out)

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout: https://hg.mozilla.org/mozilla-central/rev/be8abf34c449

Comment 11

[Makoto Kato [:m_kato]]

Attachment: Bug 1340393 - Remove -FS option on SIMPLE_PROGRAM.

Although bug 1322703 is backed out, we can remove -FS options to build SIMPLE_PROGRAM.

Review commit: https://reviewboard.mozilla.org/r/117860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117860/

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 8844374 [details]
Bug 1340393 - Remove -FS option on SIMPLE_PROGRAM.

https://reviewboard.mozilla.org/r/117860/#review119900

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dcf2939c5f6
Remove -FS option on SIMPLE_PROGRAM. r=glandium

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4dcf2939c5f6