1340422 - Implement path() on `d` property on SVG path element

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P2)

Description

[709922234]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170201180315

Comment 1

[709922234]

http://codepen.io/airen/pen/wgNEQo

Can create tween animation

Comment 2

[Robert Longson [:longsonr]]

Your syntax is invalid, the path keyword is incorrect. Nevertheless even without path we don't currently support this SVG 2 feature.

Comment 3

[Boris Chiou [:boris]]

This should be addressed in https://github.com/w3c/svgwg/issues/320. Not merged yet, so let's wait.

Comment 4

[Boris Chiou [:boris]]

To be clear, d property/attribute doesn't support path() function, so Gecko cannot render the path correctly.

Comment 5

[Sean Voisen (:svoisen)]

Now that we triage by severity, setting this bug's priority to P2 to represent near-term backlog status. See https://wiki.mozilla.org/Platform/Layout#Backlog_Tracking_in_Bugzilla

Comment 6

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 1: Add SVG d property in CSS.

Comment 7

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 2: Map SVG d attribute to CSS.

We parse the attribute and store into CSS.

Comment 8

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 3: Resolve SVG path from CSS.

Use the style value when building the SVG path and its display items.
Besides, we should also invalid the cache when there are any CSS updates.

Comment 9

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 4: Resolve SVG Marker points of path from CSS.

Comment 10

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 5: Factor out some utility inline functions in SVGPathData.cpp.

Comment 11

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 6: Factor out part of Elliptical arc implementation.

Comment 12

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 7: Notify style system when SMIL animation changes d attribute.

Comment 13

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 8: Optimize attribute mapping by not parsing svg path string again.

Unfortunately, we still have to convert the cpp version into rust version.
However, it's still better than parsing it again.

Comment 14

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 9: Update devtool tests for auto-completion.

Now we have d property, so the list of auto completion should include d
property when typing 'd'. We need to add more tabs or up/down keys to
choose the keyword we want.

Comment 15

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 11: Enable pref on nightly.

Comment 16

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 3-1: Update getPathSegListAtLength.

This will be merged into part 3 after getting r+.

Comment 17

[Boris Chiou [:boris]]

Attachment: Bug 1340422 - Part 10: Use style for GetDistancesFromOriginToEndsOfVisibleSegments().

When using a mpath elememt which linked to a external path element, we use
GetDistancesFromOriginToEndsOfVisibleSegments() to do a quick check if we
really need to build the path (note: see
SVGMotionSMILAnimationFunction::RebuildPathAndVerticesFromMpathElem),
so we have to get the d property value from style in this function.

Comment 18

[Boris Chiou [:boris]]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=01d67fae9451642eae73e4fabbbdaa3f0de1b834&selectedTaskRun=IRYngAj7T9eiCMt5YOytYg.0

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e60664181ba
Part 1: Add SVG d property in CSS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/44fd66676b8c
Part 2: Map SVG d attribute to CSS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/8ae9761a40ee
Part 3: Resolve SVG path from CSS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/22a2ccbad39c
Part 4: Resolve SVG Marker points of path from CSS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a1b8cf1afda3
Part 5: Factor out some utility inline functions in SVGPathData.cpp. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1321ace60cdd
Part 6: Factor out part of Elliptical arc implementation. r=emilio
https://hg.mozilla.org/integration/autoland/rev/f3fd6d964758
Part 7: Notify style system when SMIL animation changes d attribute. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b6d681d6d66d
Part 8: Optimize attribute mapping by not parsing svg path string again. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b26fb23539f7
Part 9: Update devtool tests for auto-completion. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/4ee3b8eb9c61
Part 10: Use style for GetDistancesFromOriginToEndsOfVisibleSegments(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/52f82029a1e5
Part 11: Enable pref on nightly. r=emilio

Comment 20

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29318 for changes under testing/web-platform/tests

Comment 21

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8e60664181ba
https://hg.mozilla.org/mozilla-central/rev/44fd66676b8c
https://hg.mozilla.org/mozilla-central/rev/8ae9761a40ee
https://hg.mozilla.org/mozilla-central/rev/22a2ccbad39c
https://hg.mozilla.org/mozilla-central/rev/a1b8cf1afda3
https://hg.mozilla.org/mozilla-central/rev/1321ace60cdd
https://hg.mozilla.org/mozilla-central/rev/f3fd6d964758
https://hg.mozilla.org/mozilla-central/rev/b6d681d6d66d
https://hg.mozilla.org/mozilla-central/rev/b26fb23539f7
https://hg.mozilla.org/mozilla-central/rev/4ee3b8eb9c61
https://hg.mozilla.org/mozilla-central/rev/52f82029a1e5

Comment 22

[Sean Voisen (:svoisen)]

Hooray! Happy to see this fixed :)

Comment 23

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 25

[marco.nelissen]

This doesn't appear fixed, or maybe there's another bug?
https://codepen.io/therealmarcone/pen/OJjeBpw draws the path in Chrome, but not in Firefox 94.0.2 nor in 78.15.0esr.

Comment 26

[Boris Chiou [:boris]]

(In reply to marco.nelissen from comment #25)

This doesn't appear fixed, or maybe there's another bug?
https://codepen.io/therealmarcone/pen/OJjeBpw draws the path in Chrome, but not in Firefox 94.0.2 nor in 78.15.0esr.

Did you enable the preference (i.e. layout.css.d-property.enabled)? I saw a path inside the button. The preference is enabled on only Nightly channel now.

Comment 27

[Boris Chiou [:boris]]

Attachment: ScreenShot for comment 25

The result on Nightly for the test in comment 25.

Comment 28

[marco.nelissen]

No, I didn't enable the preference, because I didn't realize that was necessary in order to actually enable a bugfix from 6 months ago in a build from 2 days ago. Will it ever be enabled by default?

Comment 29

[Boris Chiou [:boris]]

(In reply to marco.nelissen from comment #28)

No, I didn't enable the preference, because I didn't realize that was necessary in order to actually enable a bugfix from 6 months ago in a build from 2 days ago. Will it ever be enabled by default?

Yes. We would like to enable it by default after finishing Bug 1714238 and Bug 1715387.