1340457 - Perma failure leakcheck | default process: 120 bytes leaked (CSSVariableValues, nsStyleVariables, nsTArray_base)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Treeherder Bug Filer]

Filed by: cbook [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=78209054&repo=autoland

https://queue.taskcluster.net/v1/task/SQ8t7lvsRx69o5Lhh_gPFg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Carsten Book [:Tomcat]]

this seems a new perma failure

Comment 3

[Emilio Cobos Álvarez (:emilio)]

May this be becasu

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Grr, another half-written comment, I need to start looking at the textbox when switching tabs back. The only nsStyleVariables we should have is the static one we use to stub them, so this is slightly scary.

Comment 5

[Andrew McCreight [:mccr8]]

Well, you are only leaking one. Maybe it is stored in a static variable somewhere, and that isn't being cleaned up at shutdown?

Comment 6

[Intermittent Failures Robot]

65 failures in 180 pushes (0.361 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* autoland: 40
* mozilla-inbound: 20
* try: 3
* mozilla-central: 2

Platform breakdown:
* linux64-stylo: 65

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1340457&startday=2017-02-17&endday=2017-02-17&tree=all

Comment 7

[Cameron McCormack (:heycam)]

The leak comes from test_variables.html (maybe unsurprisingly).  I'll disable the test for now.

Comment 8

[Cameron McCormack (:heycam)]

Yes, I'm pretty sure this comes from the lazily created Variables struct:

lazy_static! {
    static ref EMPTY_VARIABLES_STRUCT: nsStyleVariables = {
        unsafe {
            let mut variables: nsStyleVariables = unsafe { zeroed() };
            Gecko_Construct_nsStyleVariables(&mut variables);
            variables
        }
    };
}

Comment 9

[Cameron McCormack (:heycam)]

https://github.com/servo/servo/pull/15629

Comment 10

[Intermittent Failures Robot]

101 failures in 833 pushes (0.121 failures/push) were associated with this bug in the last 7 days. 

This is the #20 most frequent failure this week. 

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:
* autoland: 74
* mozilla-inbound: 20
* try: 4
* mozilla-central: 2
* graphics: 1

Platform breakdown:
* linux64-stylo: 101

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1340457&startday=2017-02-13&endday=2017-02-19&tree=all

Comment 11

[Intermittent Failures Robot]

26 failures in 90 pushes (0.289 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* mozilla-inbound: 16
* autoland: 6
* graphics: 3
* mozilla-central: 1

Platform breakdown:
* linux64-stylo: 26

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1340457&startday=2017-02-20&endday=2017-02-20&tree=all

Comment 12

[Intermittent Failures Robot]

29 failures in 812 pushes (0.036 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 16
* graphics: 6
* autoland: 6
* mozilla-central: 1

Platform breakdown:
* linux64-stylo: 29

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1340457&startday=2017-02-20&endday=2017-02-26&tree=all