1340561 - stylo: figure out why layout/svg/crashtests/606914.xhtml is NOT asserting

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

In Gecko, this produces:

###!!! ASSERTION: Can't solve for both start and end: 'NS_AUTOOFFSET != aOffsets->IEnd(outerWM)', file layout/generic/nsAbsoluteContainingBlock.cpp, line 538

twice.  In stylo it does not.  So presumably stylo is feeding different numbers into layout here.  Would be good to figure out what that difference is.

Comment 1

[Manish Goregaokar [:manishearth]]

The assert seems to get fixed by https://github.com/servo/servo/pull/16229 , though I'm not sure why -- that should not be introducing a behavior different wrt layout

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yes, we're matching the clamping behavior for lengths with Gecko now, so the nscoord values layout gets now match between both.

Comment 3

[Jeremy Chen ([e-mail])]

I think this has been resolved, and the test should be fixed in part of Bug 1342596. I'll push a followup to update the comments and we should be able to resolve this bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb0bcb60da8e
fix comment for the re-enabled svg crashtest. comment-only, no review, DONTBUILD

Comment 5

[Jeremy Chen ([e-mail])]

Hmm, I should probably push the followup in Bug 1342596, and set this as a dup of Bug 1342596...

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb0bcb60da8e

Comment 7

[Gerry Chang [:gchang]]

54 RC build is released. Mark 54 won't fix.