stylo: figure out why layout/svg/crashtests/606914.xhtml is NOT asserting

RESOLVED FIXED in Firefox 55

Status

()

defect
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bzbarsky, Assigned: jeremychen)

Tracking

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 wontfix, firefox55 fixed)

Details

In Gecko, this produces:

###!!! ASSERTION: Can't solve for both start and end: 'NS_AUTOOFFSET != aOffsets->IEnd(outerWM)', file layout/generic/nsAbsoluteContainingBlock.cpp, line 538

twice.  In stylo it does not.  So presumably stylo is feeding different numbers into layout here.  Would be good to figure out what that difference is.
Priority: -- → P3
Blocks: stylo-svg
The assert seems to get fixed by https://github.com/servo/servo/pull/16229 , though I'm not sure why -- that should not be introducing a behavior different wrt layout
Yes, we're matching the clamping behavior for lengths with Gecko now, so the nscoord values layout gets now match between both.
I think this has been resolved, and the test should be fixed in part of Bug 1342596. I'll push a followup to update the comments and we should be able to resolve this bug.
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb0bcb60da8e
fix comment for the re-enabled svg crashtest. comment-only, no review, DONTBUILD
Assignee: nobody → jeremychen
Status: NEW → ASSIGNED
Hmm, I should probably push the followup in Bug 1342596, and set this as a dup of Bug 1342596...
https://hg.mozilla.org/mozilla-central/rev/eb0bcb60da8e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
54 RC build is released. Mark 54 won't fix.
You need to log in before you can comment on or make changes to this bug.