Closed
Bug 1340618
Opened 8 years ago
Closed 8 years ago
Don't hardcode Firefox in strings for space disk warning in Preferences
Categories
(Firefox :: Site Permissions, defect)
Firefox
Site Permissions
Tracking
()
RESOLVED
FIXED
Firefox 54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: flod, Assigned: Fischer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [storage-v1])
Attachments
(1 file)
Several strings landed in bug 1323395 have hard-coded "Firefox", while they should use a variable for branding
https://hg.mozilla.org/mozilla-central/diff/bc92ac281e5e/browser/locales/en-US/chrome/browser/preferences/preferences.properties
|
||
Updated•8 years ago
|
|
|
||
Comment 1•8 years ago
|
||
I filed bug 1340651 to add a test that will run to make sure we don't check in strings with "Firefox" in them by accident. I'll put a patch up there shortly.
|
|
||
Updated•8 years ago
|
Flags: needinfo?(fliu)
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8839030 [details]
Bug 1340618 - Don't hardcode Firefox in strings for space disk warning in Preferences
Jaws,
Updated to use the `brandShortName` in the brand.properties instead of a hard-coded "Firefox", thanks.
Flags: needinfo?(fliu)
Attachment #8839030 -
Flags: review?(jaws)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [storage-v1]
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8839030 [details]
Bug 1340618 - Don't hardcode Firefox in strings for space disk warning in Preferences
https://reviewboard.mozilla.org/r/113784/#review115596
Attachment #8839030 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=facc71b9c7a313fc30051b84fb89fb35848dda90
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/139294baffa2
Don't hardcode Firefox in strings for space disk warning in Preferences r=jaws
Keywords: checkin-needed
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in
before you can comment on or make changes to this bug.
Description
•