1340708 - Stylo platform types aren't in a predictable order

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I was under the impression[1] that the platform option types (opt,debug,etc) are always shown in a particular order on Treeherder, but Stylo seems to not be following that order[2] (opt and debug switch orders on some pushes).


1. https://github.com/mozilla/treeherder/blob/891b6a65c42787e0acb501bca567c0cf77ae1783/ui/js/values.js#L84


2. https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=c4b31df6a118d974e6f7bfc9ab7767c9ed0dc098&filter-searchStr=stylo%20(b)&group_state=expanded&selectedJob=78466754

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Does the stylo platform stuff have to be added to thPlatformMap to pick up the deterministic ordering?

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:styloplatform > mozilla:master

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8842675 [details] [review]
[treeherder] KWierso:styloplatform > mozilla:master

This seems to enforce the opt/debug ordering.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bf2cbaecfbcc0f8776b25432803f271b1aab9fe7
Bug 1340708 - Add stylo builds to thPlatformMap (#2218) r=camd