Closed Bug 1340717 Opened 5 years ago Closed 5 years ago

stylo: figure out whether we can optimize the change hint for table frames better

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox54 --- affected

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

Right now we pass the same change hint for both the table wrapper and the table.  It's not clear whether we can, or should, do better for the latter by excluding things the parent will handle.  Just passing NS_HintsNotHandledForDescendantsIn(changeHint) is NOT right, because that can produce invalid hints that fail this assert in nsStyleChangeList::AppendChange:

  MOZ_ASSERT(!(aHint & nsChangeHint_AllReflowHints) ||
             (aHint & nsChangeHint_NeedReflow),
             "Reflow hint bits set without actually asking for a reflow");

(because it will copy some reflow bits, but doesn't seem to copy NeedReflow?).

Cameron, do you have time to look at this? I can do it, but will be a bit slow; we've grown a lot of changehint complexity since I last looked at it.
Flags: needinfo?(cam)
Blocks: stylo
I wonder if NS_RemoveSubsumedHints in the bug 1301258 patches does the right thing?
Flags: needinfo?(cam)
That seems pretty likely, yes.
Depends on: 1301258
Note that in bug 1340723 I'm going to move this stuff to a somewhat different setup which might effectively make this bug moot.
Boris, is this moot now per comment 3?
Blocks: stylo-perf
No longer blocks: stylo
Flags: needinfo?(bzbarsky)
Priority: -- → P4
I think so, yes.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(bzbarsky)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.