1340871 - Content need to know webrender is using ANGLE or not.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Content need to know webrender is using ANGLE or not in order to determine which shared buffer should be created. I have two approach here.

1. Add a new LayersBackend, e.g. LAYERS_WR_ANGLE.
2. Or add a attribute to CompositorOptions, e.g. mUseANGLE.

I think approach 2 makes more sense to me. kats, what do you think?

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

ni kats for comment 0.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I also prefer option 2

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

I found that TextureFactoryIdentifier is more suitable for this case.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1340871 - Add CompositorUseANGLE info to TextureFactoryIdentifier.

Review commit: https://reviewboard.mozilla.org/r/113796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113796/

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8839052 [details]
Bug 1340871 - Add CompositorUseANGLE info to TextureFactoryIdentifier.

https://reviewboard.mozilla.org/r/113796/#review115546

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8feabf34de81

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/02a1b5cd91db
Add CompositorUseANGLE info to TextureFactoryIdentifier. r=nical

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/02a1b5cd91dbccf7ad95c2090d620501ff273f28