Closed Bug 1340997 Opened 3 years ago Closed 3 years ago

implement external image handler in RendererOGL

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: jerry, Assigned: jerry)

References

Details

Attachments

(2 files, 2 obsolete files)

rebase
2.37 KB, patch
sotaro
: review+
Details | Diff | Splinter Review
rebase
9.42 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
When we try to pass a external gl texture to WR, the gl texture should use the same gl context as the RendererOGL has. So, I think it's better to implement the handler in RendererOGL.
The name of "WrExternalImageIdId" is a little bit strange.

MozReview-Commit-ID: 8pfWxg5XuYS
Attachment #8839089 - Flags: review?(nical.bugzilla)
MozReview-Commit-ID: LfjnTRwUCao
Attachment #8839090 - Flags: review?(nical.bugzilla)
Comment on attachment 8839090 [details] [diff] [review]
add external image callback in RendererOGL.

Review of attachment 8839090 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/WebRenderAPI.cpp
@@ +47,5 @@
>  
>      gl->fGetIntegerv(LOCAL_GL_MAX_TEXTURE_SIZE, mMaxTextureSize);
>  
>      WrRenderer* wrRenderer = nullptr;
> +    if (!wr_window_new(aWindowId, gl.get(), this->mEnableProfiler, mWrApi, &wrRenderer)) {

When we call wr_window_new, the rendererOGL is not ready here. So, move the setting of externalImageHandler to another function.
See Also: → 1341235
Blocks: 1341235
Attached patch rebase — — Splinter Review
Attachment #8842323 - Flags: review?(sotaro.ikeda.g)
Attachment #8839089 - Attachment is obsolete: true
Attachment #8839089 - Flags: review?(nical.bugzilla)
Attached patch rebase — — Splinter Review
Attachment #8842324 - Flags: review?(sotaro.ikeda.g)
Attachment #8839090 - Attachment is obsolete: true
Attachment #8839090 - Flags: review?(nical.bugzilla)
Attachment #8842323 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8842324 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/169c2f5176bb
rename the external image related structure in webrender_ffi. r=sotaro
https://hg.mozilla.org/projects/graphics/rev/e306b40ff823
add external image callback in RendererOGL. r=sotaro
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.