Closed
Bug 1340997
Opened 8 years ago
Closed 8 years ago
implement external image handler in RendererOGL
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jerry, Assigned: jerry)
References
Details
Attachments
(2 files, 2 obsolete files)
2.37 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
9.42 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
When we try to pass a external gl texture to WR, the gl texture should use the same gl context as the RendererOGL has. So, I think it's better to implement the handler in RendererOGL.
Assignee | ||
Comment 1•8 years ago
|
||
The name of "WrExternalImageIdId" is a little bit strange.
MozReview-Commit-ID: 8pfWxg5XuYS
Attachment #8839089 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 2•8 years ago
|
||
MozReview-Commit-ID: LfjnTRwUCao
Attachment #8839090 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8839090 [details] [diff] [review]
add external image callback in RendererOGL.
Review of attachment 8839090 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/webrender_bindings/WebRenderAPI.cpp
@@ +47,5 @@
>
> gl->fGetIntegerv(LOCAL_GL_MAX_TEXTURE_SIZE, mMaxTextureSize);
>
> WrRenderer* wrRenderer = nullptr;
> + if (!wr_window_new(aWindowId, gl.get(), this->mEnableProfiler, mWrApi, &wrRenderer)) {
When we call wr_window_new, the rendererOGL is not ready here. So, move the setting of externalImageHandler to another function.
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8842323 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Updated•8 years ago
|
Attachment #8839089 -
Attachment is obsolete: true
Attachment #8839089 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8842324 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Updated•8 years ago
|
Attachment #8839090 -
Attachment is obsolete: true
Attachment #8839090 -
Flags: review?(nical.bugzilla)
Updated•8 years ago
|
Attachment #8842323 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•8 years ago
|
Attachment #8842324 -
Flags: review?(sotaro.ikeda.g) → review+
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/169c2f5176bb
rename the external image related structure in webrender_ffi. r=sotaro
https://hg.mozilla.org/projects/graphics/rev/e306b40ff823
add external image callback in RendererOGL. r=sotaro
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/169c2f5176bb
https://hg.mozilla.org/mozilla-central/rev/e306b40ff823
status-firefox54:
--- → fixed
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•