1340997 - implement external image handler in RendererOGL

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

When we try to pass a external gl texture to WR, the gl texture should use the same gl context as the RendererOGL has. So, I think it's better to implement the handler in RendererOGL.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: rename the external image related structure in webrender_ffi.

The name of "WrExternalImageIdId" is a little bit strange.

MozReview-Commit-ID: 8pfWxg5XuYS

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: add external image callback in RendererOGL.

MozReview-Commit-ID: LfjnTRwUCao

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8839090 [details] [diff] [review]
add external image callback in RendererOGL.

Review of attachment 8839090 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/WebRenderAPI.cpp
@@ +47,5 @@
>  
>      gl->fGetIntegerv(LOCAL_GL_MAX_TEXTURE_SIZE, mMaxTextureSize);
>  
>      WrRenderer* wrRenderer = nullptr;
> +    if (!wr_window_new(aWindowId, gl.get(), this->mEnableProfiler, mWrApi, &wrRenderer)) {

When we call wr_window_new, the rendererOGL is not ready here. So, move the setting of externalImageHandler to another function.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: rebase

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: rebase

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/169c2f5176bb
rename the external image related structure in webrender_ffi. r=sotaro
https://hg.mozilla.org/projects/graphics/rev/e306b40ff823
add external image callback in RendererOGL. r=sotaro

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/169c2f5176bb
https://hg.mozilla.org/mozilla-central/rev/e306b40ff823