Status
()
People
(Reporter: jerry, Assigned: jerry)
Tracking
Firefox Tracking Flags
(firefox54 fixed)
Details
Attachments
(2 attachments, 2 obsolete attachments)
|
2.37 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
|
9.42 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
When we try to pass a external gl texture to WR, the gl texture should use the same gl context as the RendererOGL has. So, I think it's better to implement the handler in RendererOGL.
|
(Assignee) | |
Comment 1•2 years ago
|
||
Created attachment 8839089 [details] [diff] [review] rename the external image related structure in webrender_ffi. The name of "WrExternalImageIdId" is a little bit strange. MozReview-Commit-ID: 8pfWxg5XuYS
Attachment #8839089 -
Flags: review?(nical.bugzilla)
|
|
(Assignee) | |
Comment 2•2 years ago
|
||
Created attachment 8839090 [details] [diff] [review] add external image callback in RendererOGL. MozReview-Commit-ID: LfjnTRwUCao
Attachment #8839090 -
Flags: review?(nical.bugzilla)
|
|
(Assignee) | |
Comment 3•2 years ago
|
||
Comment on attachment 8839090 [details] [diff] [review] add external image callback in RendererOGL. Review of attachment 8839090 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/webrender_bindings/WebRenderAPI.cpp @@ +47,5 @@ > > gl->fGetIntegerv(LOCAL_GL_MAX_TEXTURE_SIZE, mMaxTextureSize); > > WrRenderer* wrRenderer = nullptr; > + if (!wr_window_new(aWindowId, gl.get(), this->mEnableProfiler, mWrApi, &wrRenderer)) { When we call wr_window_new, the rendererOGL is not ready here. So, move the setting of externalImageHandler to another function.
|
||
Updated•2 years ago
|
||
See Also: → bug 1341235
|
|
(Assignee) | |
Comment 4•2 years ago
|
||
Created attachment 8842323 [details] [diff] [review] rebase
Attachment #8842323 -
Flags: review?(sotaro.ikeda.g)
|
|
(Assignee) | |
Updated•2 years ago
|
||
Attachment #8839089 -
Attachment is obsolete: true
Attachment #8839089 -
Flags: review?(nical.bugzilla)
|
|
(Assignee) | |
Comment 5•2 years ago
|
||
Created attachment 8842324 [details] [diff] [review] rebase
Attachment #8842324 -
Flags: review?(sotaro.ikeda.g)
|
|
(Assignee) | |
Updated•2 years ago
|
||
Attachment #8839090 -
Attachment is obsolete: true
Attachment #8839090 -
Flags: review?(nical.bugzilla)
|
||
Updated•2 years ago
|
||
Attachment #8842323 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Updated•2 years ago
|
||
Attachment #8842324 -
Flags: review?(sotaro.ikeda.g) → review+
Pushed by hshih@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/169c2f5176bb rename the external image related structure in webrender_ffi. r=sotaro https://hg.mozilla.org/projects/graphics/rev/e306b40ff823 add external image callback in RendererOGL. r=sotaro
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/169c2f5176bb https://hg.mozilla.org/mozilla-central/rev/e306b40ff823
status-firefox54: --- → fixed
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•