59 bytes, text/x-review-board-request
I'm working on enabling no-undef eslint rule for toolkit/ and I discovered this error: /Users/mark/dev/gecko/toolkit/content/widgets/popup.xml 725:10 error 'menupopup' is not defined. no-undef (eslint) This is in the `mousemove` handler for the popup-scrollbars. It looks like the `menupopup.releaseCapture()` should be `this.releaseCapture()`. I also wonder if this may have been part of the cause of the issues for bug 1332708.
Comment on attachment 8839148 [details] Bug 1341031 - Fix releasing drag capture for popups. https://reviewboard.mozilla.org/r/113868/#review115606 Thanks! Glad to see these rules catching real bugs!
Attachment #8839148 - Flags: review?(mconley) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2cec05d38d05 Fix releasing drag capture for popups. r=mconley
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.