Closed
Bug 1341056
Opened 9 years ago
Closed 9 years ago
Stop setting a border for .button-box on Linux
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: dao, Assigned: deepsrijit1105)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 1 obsolete file)
|
1.17 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
We add a transparent border and change it to a dotted on one focus, but that border is never used because -moz-appearance: button-focus takes precedence:
https://hg.mozilla.org/mozilla-central/annotate/16effd5b21ab03629feca04b5b83911bb757394c/toolkit/themes/linux/global/button.css#l21
|
Reporter | |
Updated•9 years ago
|
status-firefox54:
affected → ---
Hi Dao,
Will this work?
Thanks.
Attachment #8839645 -
Flags: review?(dao+bmo)
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8839645 [details] [diff] [review]
initial_patch
This is halfway there. You also need to remove the button:focus > .button-box rule.
Attachment #8839645 -
Flags: review?(dao+bmo) → review-
|
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → deepsrijit1105
I have changed as per the suggestion. Thanks.
Attachment #8839645 -
Attachment is obsolete: true
Attachment #8840009 -
Flags: review?(dao+bmo)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8840009 [details] [diff] [review]
updated_patch
Looks good, thanks!
Attachment #8840009 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/869ee93548d3
Stop setting a border for .button-box on Linux. r=dao
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•