Stop setting a border for .button-box on Linux

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: deepsrijit1105)

Tracking

({good-first-bug})

Trunk
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

1.17 KB, patch
dao
: review+
Details | Diff | Splinter Review
We add a transparent border and change it to a dotted on one focus, but that border is never used because -moz-appearance: button-focus takes precedence:

https://hg.mozilla.org/mozilla-central/annotate/16effd5b21ab03629feca04b5b83911bb757394c/toolkit/themes/linux/global/button.css#l21
Posted patch initial_patch (obsolete) — Splinter Review
Hi Dao,

Will this work?

Thanks.
Attachment #8839645 - Flags: review?(dao+bmo)
Comment on attachment 8839645 [details] [diff] [review]
initial_patch

This is halfway there. You also need to remove the button:focus > .button-box rule.
Attachment #8839645 - Flags: review?(dao+bmo) → review-
Assignee: nobody → deepsrijit1105
Posted patch updated_patchSplinter Review
I have changed as per the suggestion. Thanks.
Attachment #8839645 - Attachment is obsolete: true
Attachment #8840009 - Flags: review?(dao+bmo)
Comment on attachment 8840009 [details] [diff] [review]
updated_patch

Looks good, thanks!
Attachment #8840009 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/869ee93548d3
Stop setting a border for .button-box on Linux. r=dao
https://hg.mozilla.org/mozilla-central/rev/869ee93548d3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Depends on: 1342368
Blocks: 1348495
You need to log in before you can comment on or make changes to this bug.