1341080 - Crash in wrap_strdup | mozilla::Version::Version

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jukka Jylänki]

This bug was filed from the Socorro interface and is 
report bp-4992537d-b1a6-4e0e-8c58-8846b2170220.
=============================================================

FF Nightly crashes on slow script dialog coming up in Wasm.

Comment 1

[Jukka Jylänki]

Occurs somewhat deterministically, another callstack:

https://crash-stats.mozilla.com/report/index/81391e44-8780-4b8b-b64c-575182170220

Comment 2

[Jukka Jylänki]

Unfortunately the test case is not public, but can be provided as needed.

Comment 3

[Luke Wagner [:luke]]

D'oh, looks like another case of forgetting filename can be null (and, in this case, calling strdup on filename in DescribeScriptedCaller()).

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: fix.patch

The hardest was to make a test case.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8839237 [details] [diff] [review]
fix.patch

Review of attachment 8839237 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, that was fast, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bccce8de17e
Provide an empty filename if the wasm caller doesn't have one in DescribeScriptedCaller; r=luke

Comment 7

[Luke Wagner [:luke]]

This seems to repro pretty easily for slow-script-dialog on Aurora/Beta, so it'd be good to uplift.

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8839237 [details] [diff] [review]
fix.patch

Approval Request Comment
[Feature/Bug causing the regression]: wasm
[User impact if declined]: crashes in slow script dialog
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes (landed this morning and tests passed)
[Needs manual test from QE? If yes, steps to reproduce]: n/a 
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: not much
[Why is the change risky/not risky?]: conservative change, one-line of code
[String changes made/needed]: n/a

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4bccce8de17e

Comment 10

[Gerry Chang [:gchang]]

Track 53- as the volume of crashes is low.

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8839237 [details] [diff] [review]
fix.patch

Fix a crash related to wasm and also include a test. Aurora53+.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8839237 [details] [diff] [review]
fix.patch

wasm crash fix for beta52

Should be in 52.0b9

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8e4f44727c5b

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d4cf6378334

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/6d4cf6378334