1341107 - Transferred size should not consider cached requests

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Leonardo Couto]

Attachment: Screen Shot 2017-02-20 at 20.47.03.png

Transferred size should not consider cached requests on the network summary sum information.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hi Leonardo,
any progress with this bug?
Do you need help?

Honza

Comment 2

[Leonardo Couto]

(In reply to Jan Honza Odvarko [:Honza] from comment #1)
> Hi Leonardo,
> any progress with this bug?
> Do you need help?
> 
> Honza

Hi Honza,

I had some health problems this week and I will be back to normal routine on monday. Probably will have a patch for it early next week if it's not a problem :)

Best,
Leonardo Couto.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Leonardo Couto from comment #2)
> I had some health problems this week and I will be back to normal routine on
> monday. Probably will have a patch for it early next week if it's not a
> problem :)
Excellent, thanks!

Honza

Comment 4

[Leonardo Couto]

Attachment: This patch fix the cached transferred requests being considered on the summary of netmonitor toolbar.

Would be good if we could check on the CI, thanks :)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8844164 [details] [diff] [review]
This patch fix the cached transferred requests being considered on the summary of netmonitor toolbar.

Review of attachment 8844164 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Can you please add a comment explaining the change.

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0e17089b7edcd2aca86e088255f9ea467712af0

Let's wait what the Try says before R+

Thanks for working on this!
Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8844164 [details] [diff] [review]
This patch fix the cached transferred requests being considered on the summary of netmonitor toolbar.

Review of attachment 8844164 [details] [diff] [review]:
-----------------------------------------------------------------

R+

Thanks!
Honza

Comment 7

[Leonardo Couto]

Cool, glad that worked !

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4df698314ec3
Don't consider cached requests on netmonitor summary. r=Honza

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4df698314ec3

Comment 10

[Ciprian Georgiu, Desktop QA]

I've reproduced the issue on Nightly from 2017-02-20 using Win 10.

This issue is verified fixed on latest Nightly 55.0a1 (2017-03-10) across platforms:
- Windows 10 x64
- Ubuntu 16.04 x64 LTS
- Mac OS X 10.11.6

Comment 11

[Kostas]

I've noticed that devtools Network Monitor counts cached requests against "transferred".
e.g. for this URL https://store.steampowered.com/search/?term= 
almost all the requests are fetched from cache (except only 1: the html one) the second time I load it,
but in Firefox 61-63 it shows: 1.03 MB / 2.61 MB transferred, 
while in Chrome 67 it shows: 22.6 KB transferred, as expected.

I even ran latest MozRegression-GUI for the interval 2017-03-06 - 2018-07-17
and the issue occurred in all builds I tested. 

STR

- in a fresh Firefox 61 x64 profile (win10), open Network Monitor
- load https://store.steampowered.com/search/?term=
- notice the Size/Transferred size values as the page loads for the first time.
- now reload the page (F5): notice that the 'Transferred size' remains the same even though almost all the the requests are fetched from cache.

Screenshots after the 2nd reload:
FF 61:     https://i.imgur.com/0KbUGmB.jpg
Chrome 67: https://i.imgur.com/Ko4DUZS.jpg