Closed Bug 1341107 Opened 4 years ago Closed 4 years ago

Transferred size should not consider cached requests

Categories

(DevTools :: Netmonitor, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 55
Iteration:
55.1 - Mar 20

People

(Reporter: leonardo.couto, Assigned: leonardo.couto, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor-reserve])

Attachments

(2 files)

Transferred size should not consider cached requests on the network summary sum information.
Assignee: nobody → leonardo.couto
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [netmonitor-reserve]
Flags: qe-verify?
Priority: P1 → P3
Flags: qe-verify? → qe-verify+
Hi Leonardo,
any progress with this bug?
Do you need help?

Honza
QA Contact: ciprian.georgiu
(In reply to Jan Honza Odvarko [:Honza] from comment #1)
> Hi Leonardo,
> any progress with this bug?
> Do you need help?
> 
> Honza

Hi Honza,

I had some health problems this week and I will be back to normal routine on monday. Probably will have a patch for it early next week if it's not a problem :)

Best,
Leonardo Couto.
(In reply to Leonardo Couto from comment #2)
> I had some health problems this week and I will be back to normal routine on
> monday. Probably will have a patch for it early next week if it's not a
> problem :)
Excellent, thanks!

Honza
Would be good if we could check on the CI, thanks :)
Attachment #8844164 - Flags: review?(odvarko)
Comment on attachment 8844164 [details] [diff] [review]
This patch fix the cached transferred requests being considered on the summary of netmonitor toolbar.

Review of attachment 8844164 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Can you please add a comment explaining the change.

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0e17089b7edcd2aca86e088255f9ea467712af0

Let's wait what the Try says before R+

Thanks for working on this!
Honza
Comment on attachment 8844164 [details] [diff] [review]
This patch fix the cached transferred requests being considered on the summary of netmonitor toolbar.

Review of attachment 8844164 [details] [diff] [review]:
-----------------------------------------------------------------

R+

Thanks!
Honza
Attachment #8844164 - Flags: review?(odvarko) → review+
Cool, glad that worked !
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4df698314ec3
Don't consider cached requests on netmonitor summary. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4df698314ec3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.1 - Mar 20
Priority: P3 → P1
I've reproduced the issue on Nightly from 2017-02-20 using Win 10.

This issue is verified fixed on latest Nightly 55.0a1 (2017-03-10) across platforms:
- Windows 10 x64
- Ubuntu 16.04 x64 LTS
- Mac OS X 10.11.6
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
I've noticed that devtools Network Monitor counts cached requests against "transferred".
e.g. for this URL https://store.steampowered.com/search/?term= 
almost all the requests are fetched from cache (except only 1: the html one) the second time I load it,
but in Firefox 61-63 it shows: 1.03 MB / 2.61 MB transferred, 
while in Chrome 67 it shows: 22.6 KB transferred, as expected.

I even ran latest MozRegression-GUI for the interval 2017-03-06 - 2018-07-17
and the issue occurred in all builds I tested. 

STR

- in a fresh Firefox 61 x64 profile (win10), open Network Monitor
- load https://store.steampowered.com/search/?term=
- notice the Size/Transferred size values as the page loads for the first time.
- now reload the page (F5): notice that the 'Transferred size' remains the same even though almost all the the requests are fetched from cache.

Screenshots after the 2nd reload:
FF 61:     https://i.imgur.com/0KbUGmB.jpg
Chrome 67: https://i.imgur.com/Ko4DUZS.jpg
You need to log in before you can comment on or make changes to this bug.