1341108 - Multi-channel audio doesn't work on ALSA-only builds

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jan Beich]

Very few libcubeb backends implement .get_preferred_channel_layout even if the underlying audio system does support multi-channel. We probably want to force stereo for Tier3 builds.

$ echo "ac_add_options --disable-pulseaudio" >>.mozconfig
$ echo "ac_add_options --enable-alsa" >>.mozconfig
$ ./mach bootstrap
$ ./mach build
$ ./mach run https://www2.iis.fraunhofer.de/AAC/multichannel.html

Comment 1

[Jan Beich]

Landry, does the page in comment 0 produce sound with sndio on Nightly for you?

Comment 2

[Landry Breuil (:gaston)]

Nightly segfaults at startup sooo... cant really tell for now :)

Comment 3

[Jan Beich]

Attachment: Bug 1341108 - Work around libcubeb backends without multi-channel support.

Review commit: https://reviewboard.mozilla.org/r/113944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113944/

Comment 4

[Jan Beich]

Comment on attachment 8839248 [details]
Bug 1341108 - Work around libcubeb backends without multi-channel support.

https://reviewboard.mozilla.org/r/113944/#review115458

Adjusting the pref based on platform seems like a bug. I'm not sure why Gecko thinks multi-channel works even if libcubeb says no.

Comment 5

[Jean-Yves Avenard [:jya]]

:chunmin do we have multi channels support on ALSA?

Comment 6

[C.M.Chang[:chunmin]]

No, we have not implemented it on ALSA yet.

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8839248 [details]
Bug 1341108 - Work around libcubeb backends without multi-channel support.

https://reviewboard.mozilla.org/r/113944/#review115540

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f92a2459194
Work around libcubeb backends without multi-channel support. r=jya

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f92a2459194