1341162 - Fix -Wunreachable-code-return warning in webrtc/signaling

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Chris Peterson [:cpeterson]]

The WebrtcVideoConduit::GetRTCPSenderReport() member function has an unnecessary scope block and unreachable `return false`.

media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:847:10 [-Wunreachable-code-return] 'return' will never be executed

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1341162 - Fix -Wunreachable-code-return warning in webrtc/signaling.

The WebrtcVideoConduit::GetRTCPSenderReport() member function has an unnecessary scope block and unreachable `return false`.

media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:847:10 [-Wunreachable-code-return] 'return' will never be executed

Review commit: https://reviewboard.mozilla.org/r/113972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113972/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8839299 [details]
Bug 1341162 - Fix -Wunreachable-code-return warning in webrtc/signaling.

https://reviewboard.mozilla.org/r/113972/#review115602

Comment 3

[Chris Peterson [:cpeterson]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4de2e38a987a
Fix -Wunreachable-code-return warning in webrtc/signaling. r=bwc

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4de2e38a987a