Closed Bug 1341162 Opened 7 years ago Closed 7 years ago

Fix -Wunreachable-code-return warning in webrtc/signaling

Categories

(Core :: WebRTC: Signaling, defect)

51 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- wontfix
firefox54 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The WebrtcVideoConduit::GetRTCPSenderReport() member function has an unnecessary scope block and unreachable `return false`.

media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:847:10 [-Wunreachable-code-return] 'return' will never be executed
Comment on attachment 8839299 [details]
Bug 1341162 - Fix -Wunreachable-code-return warning in webrtc/signaling.

https://reviewboard.mozilla.org/r/113972/#review115602
Attachment #8839299 - Flags: review?(docfaraday) → review+
Thanks!
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4de2e38a987a
Fix -Wunreachable-code-return warning in webrtc/signaling. r=bwc
https://hg.mozilla.org/mozilla-central/rev/4de2e38a987a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.