Closed Bug 1341258 Opened 3 years ago Closed 3 years ago

whitespace-only text node shows up as "o"

Categories

(DevTools :: Inspector, enhancement, P3)

52 Branch
enhancement

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: lb1.3, Assigned: jdescottes)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170220231536

Steps to reproduce:

Opened inspector on some html with enter between elements.


Actual results:

Whitespace-only text node shows up as "o" in the inspector... why? 


Expected results:

shouldn't show this bogus "o", I thought there was typo in output code.
Any testcase, please?
Component: Untriaged → Developer Tools: Inspector
Flags: needinfo?(lb1.3)
Attached image Screenshot
Flags: needinfo?(lb1.3)
Bug 1304685.


It should have some descriptive, such as tooltip.
Blocks: 1304685
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
Summary: whitespace-only text node → whitespace-only text node shows up as "o"
Attached image whitespace.jpg
(In reply to YF (Yang) from comment #3)
> Bug 1304685.
> 
> 
> It should have some descriptive, such as tooltip.

It's already the case in Nightly, I don't think there is something to fix here. :)
(In reply to Loic from comment #4)
> Created attachment 8839565 [details]
> whitespace.jpg
> 
> (In reply to YF (Yang) from comment #3)
> > Bug 1304685.
> > 
> > 
> > It should have some descriptive, such as tooltip.
> 
> It's already the case in Nightly, I don't think there is something to fix
> here. :)

Looks good, but can be better if the tooltip hot area (trigger) is bigger.
Severity: normal → minor
We display whitespace text nodes in the inspector if they have an impact on the layout. Such text nodes often create hard to understand layout issues (gaps between nodes etc...), and most inspectors don't let developers inspect them.

Now the representation can probably be improved to avoid the confusion with the letter "o". We discussed several proposals for the initial implementation in Bug 1304685. My initial idea was https://bug1304685.bmoattachments.org/attachment.cgi?id=8794103
I still like it, because it's hard to mistake it for another element (maybe the fading was too much).
Patrick: what do you think about updating the representation here?
Severity: minor → enhancement
Flags: needinfo?(pbrosset)
Priority: -- → P3
(In reply to Julian Descottes [:jdescottes] from comment #7)
> Patrick: what do you think about updating the representation here?
Sure, I'm not against it, especially if the character we chose gets confused with the 'o' letter.
Attachment 8794103 [details] looks good to me especially because it looks exactly like the [...] icon we have in between an opening and closing tag when the element has child nodes. So I see the value of consistency here.
Flags: needinfo?(pbrosset)
Attachment #8841514 - Flags: review?(gl) → review+
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bf5cd5c076b
update display of whitespace nodes in markup view;r=gl
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6bf5cd5c076b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I have reproduced this bug with Nightly 54.0a1 (2017-02-21) (64-bit) on Manjaro Linux 17!

This bug's fix is verified with latest Beta!

Build ID 	20170511200247
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

[testday-20170512]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.