Closed Bug 1341282 Opened 3 years ago Closed 3 years ago
The telemetry session id field of the crash ping sent by the crashreporter client is wrong
59 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1310703 +++ QA noticed that the |payload.sessionId| field in the crash ping sent by the crashreporter client is different than the one sent by Firefox when restarting. It turns out we write out the wrong value to the extra file which is causing this issue; the value written out to the event file is correct though.
While writing a test for this I also noticed that one of the tests I wrote for bug 1310703 is wrong... I wonder why it doesn't blow up on try though.
This should fail (and it does locally on my machine): https://dxr.mozilla.org/mozilla-central/rev/d0462b0948e0b1147dcce615bddcc46379bdadb2/toolkit/crashreporter/test/unit/test_crashreporter_crash.js#49
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8839841 [details] Bug 1341282 - Write the telemetry session id to the .extra file during a crash; https://reviewboard.mozilla.org/r/114420/#review117992 Wow, that was silly. :)
Attachment #8839841 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5) > Comment on attachment 8839841 [details] > Bug 1341282 - Write the telemetry session id to the .extra file during a > crash; > > https://reviewboard.mozilla.org/r/114420/#review117992 > > Wow, that was silly. :) Yeah, copy-paste mistake before landing :-/ Anyway, thanks for the review, here's the green try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cec535b99e99d2e4d76c235a32a3288a7fe5828
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a06d9da18b Write the telemetry session id to the .extra file during a crash; r=Ted
QA verified. Both pings have identical SessionId.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.