1341301 - Resending form post data is broken if a service worker is registered

Status: NEW

(Core :: DOM: Service Workers, defect, P2)

Description

[Cătălin Badea (:catalinb)]

When resubmitting form requests (refresh + resend dialog), if a service worker is registered, intercepts the request, but then resets the channel (fetch handler that doesn't call .respondWith) - firefox will not send the correct Content-Length and Content-Type headers.

This happens because we reuse a nsStorageInputStream stored in history that doesn't contain these headers.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1333182#c10 and bug 1337033.

We should use a different input stream that preserves the header information from nsMIMEInputStream and write a test that covers resending post data.

Comment 1

[Hidehisa YASUDA]

Hello guys.
Thank you for great software.

I'm suffuring from this 1-year-old bug these days (with my CMS).

I made a page to reproduce this bug:
https://nebosuker.net/ff59-form-repost/

I'm very happy if Firefox dev team fix this bug...

Thanks.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Thanks for the test case.  I'll try to take a look.

Comment 3

[Hidehisa YASUDA]

Thank you Ben!
I'm very happy to hear that!

Comment 4

[Cătălin Badea (:catalinb)]

(In reply to Ben Kelly [Part-time, not reviewing][:bkelly] from comment #2)
> Thanks for the test case.  I'll try to take a look.

why the needinfo? :) Is there anything I can do to help?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Sorry, I meant to NI myself, but must have hit reporter by accident.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Sorry, I never found time to investigate this.

Comment 7

[Hidehisa YASUDA]

Wow, is this bug already fixed?

I tested on https://nebosuker.net/ff59-form-repost/ and it seems to work fine!

Thank you dev team!