Closed Bug 1341307 Opened 3 years ago Closed 3 years ago

Remove useless a "using" declaration

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: l1peu2tout, Assigned: l1peu2tout)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch mon-patch.diff (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Running some toolings, I found that some "using" declarations are useless.
Attachment #8839497 - Flags: review?(nical.bugzilla)
Attachment #8839497 - Attachment is patch: true
Attachment #8839497 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8839497 [details] [diff] [review]
mon-patch.diff

Review of attachment 8839497 [details] [diff] [review]:
-----------------------------------------------------------------

Congrats for you first patch!
Attachment #8839497 - Flags: review?(nical.bugzilla) → review+
Assignee: nobody → l1peu2tout
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59f04be1efe9
Remove useless using declaration in SkiaGLGlue.cpp. r=nical
Bravo for this first patch!
Summary: Remove useless using declarations → Remove useless a "using" declaration
https://hg.mozilla.org/mozilla-central/rev/59f04be1efe9
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.