Closed Bug 1341407 Opened 8 years ago Closed 8 years ago

Upgrade Neutrino dependency

Tracking

(Not tracked)

Status:

RESOLVED FIXED

People

(Reporter: davidwalsh, Assigned: davidwalsh)

Details

Attachments

(6 files, 2 obsolete files)

autoland-ui: Upgrade Neutrino to version 4+ (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request	imadueme : review+	Details
autoland-ui: Update yarn.lock for Neutrino upgrade (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request	imadueme : review+	Details
autoland-ui: Update test framework to use neutrino-preset-jest (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request	imadueme : review+	Details
autoland-ui: Update yarn.lock for Neutrino test updates (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request		Details
autoland-ui: Fix all linting warnings after Neutrino update (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request		Details
autoland-ui: Update yarn.lock for Neutrino test updates (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request	imadueme : review+	Details
autoland-ui: Fix all linting warnings after Neutrino update (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request	imadueme : review+	Details
autoland-ui: Update yarn version (Bug 1341407). 8 years ago David Walsh :davidwalsh 59 bytes, text/x-review-board-request	imadueme : review+	Details

David Walsh :davidwalsh

Assignee

Description

•

8 years ago

Neutrino got a major update and we should stick with current versioning.

Comment hidden (mozreview-request)

David Walsh :davidwalsh

Assignee

Comment 6

•

8 years ago

mozreview-review

Comment on attachment 8839638 [details] autoland-ui: Upgrade Neutrino to version 4+ (Bug 1341407). https://reviewboard.mozilla.org/r/114200/#review115654 I need to take a break from this; everything works "locally" but I get an error about the `defaultState = { data: null, error: null, hideTry: true };` line in `AutolandController.jsx` when I run `docker-compose up`. Driving me insane.

Comment hidden (mozreview-request)

David Walsh :davidwalsh

Assignee

Updated

•

8 years ago

Attachment #8839641 - Attachment is obsolete: true

Attachment #8839641 - Flags: review?(imadueme)

David Walsh :davidwalsh

Assignee

Updated

•

8 years ago

Attachment #8839642 - Attachment is obsolete: true

Attachment #8839642 - Flags: review?(imadueme)

Israel Madueme [:imadueme]

Comment 13

•

8 years ago

mozreview-review

Comment on attachment 8839638 [details] autoland-ui: Upgrade Neutrino to version 4+ (Bug 1341407). https://reviewboard.mozilla.org/r/114202/#review116104 Nice

Attachment #8839638 - Flags: review?(imadueme) → review+

Israel Madueme [:imadueme]

Comment 14

•

8 years ago

mozreview-review

Comment on attachment 8839639 [details] autoland-ui: Update yarn.lock for Neutrino upgrade (Bug 1341407). https://reviewboard.mozilla.org/r/114204/#review116106

Attachment #8839639 - Flags: review?(imadueme) → review+

Israel Madueme [:imadueme]

Comment 15

•

8 years ago

mozreview-review

Comment on attachment 8839640 [details] autoland-ui: Update test framework to use neutrino-preset-jest (Bug 1341407). https://reviewboard.mozilla.org/r/114206/#review116108 ::: autoland/ui/Dockerfile-dev:16 (Diff revision 2) > WORKDIR /code > > COPY package.json /code > COPY conduit-preset.js /code > COPY yarn.lock /code > +COPY test/ /code/test We should volume mount this instead of copying it. You can see the docker-compose.yml file with an example.

Attachment #8839640 - Flags: review?(imadueme) → review-

Israel Madueme [:imadueme]

Comment 16

•

8 years ago

mozreview-review

Comment on attachment 8840076 [details] autoland-ui: Update yarn.lock for Neutrino test updates (Bug 1341407). https://reviewboard.mozilla.org/r/114612/#review116110

Attachment #8840076 - Flags: review?(imadueme) → review+

Israel Madueme [:imadueme]

Comment 17

•

8 years ago

mozreview-review

Comment on attachment 8840077 [details] autoland-ui: Fix all linting warnings after Neutrino update (Bug 1341407). https://reviewboard.mozilla.org/r/114614/#review116112

Attachment #8840077 - Flags: review?(imadueme) → review+

Israel Madueme [:imadueme]

Comment 18

•

8 years ago

mozreview-review

Comment on attachment 8840078 [details] autoland-ui: Update yarn version (Bug 1341407). https://reviewboard.mozilla.org/r/114616/#review116114

Attachment #8840078 - Flags: review?(imadueme) → review+

David Walsh :davidwalsh

Assignee

Comment 19

•

8 years ago

mozreview-review

Comment on attachment 8839640 [details] autoland-ui: Update test framework to use neutrino-preset-jest (Bug 1341407). https://reviewboard.mozilla.org/r/114206/#review116116 ::: autoland/ui/Dockerfile-dev:16 (Diff revision 2) > WORKDIR /code > > COPY package.json /code > COPY conduit-preset.js /code > COPY yarn.lock /code > +COPY test/ /code/test Wny wouldn't we copy over? Context? Also, are you saying to add `test` as a volume? I'm lost.

Israel Madueme [:imadueme]

Comment 20

•

8 years ago

mozreview-review-reply

Comment on attachment 8839640 [details] autoland-ui: Update test framework to use neutrino-preset-jest (Bug 1341407). https://reviewboard.mozilla.org/r/114206/#review116116 > Wny wouldn't we copy over? Context? > > Also, are you saying to add `test` as a volume? > > I'm lost. For the same reason we don't copy the src folder. Volume mounting mean that you can change the file on your machine and it will get updated in the docker container. It's not super important for tests (since docker-compose run sort of resets everything, but, I think that it's just the right way to do it). We have to copy over the files in the root dir to avoid volume mounting the entire root folder (because then we would mount the node_modules folder which we don't want).