1341540 - Label runnables in dom/html/HTMLMediaElement.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

See https://wiki.mozilla.org/Quantum/DOM for the motivation.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This includes HTMLMediaElement::ProgressTimerCallback, which shows up quite often in telemetry.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Take this bug to follow up.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch: Label runnables in dom/html/HTMLMediaElement.cpp

1. Hold the DocGroup event target at HTMLMediaElement::mMainThreadEventTarget for runnable labeling.
2. Name runnables with Runnable's constructor which accepts a name string.
3. Replace NS_DispatchToMainThread()/OwnerDoc()->Dispatch() with mMainThreadEventTarget->Dispatch()
4. Replace AbstractThread::MainThread() with mAbstractMainThread.
5. Set mMainThreadEventTarget as the event target of the nsITimers with the assumption that all these timers are initiated on the main thread.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b0ece63a9a9
Label runnables in dom/html/HTMLMediaElement.cpp. r=jwwang

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b0ece63a9a9