'ex' is not defined in TelemetryModules.jsm - logging would be incorrect

RESOLVED FIXED in Firefox 54

Status

()

defect
--
trivial
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1330833 added TelemetryModules.jsm, in bug 1341029 I'm working on getting the no-undef rule for eslint enabled.

I've just noticed this issue:

toolkit/components/telemetry/TelemetryModules.jsm
  92:59  error  'ex' is not defined.  no-undef (eslint)

Looking at the code, I think the only effect of this is that the debug logging won't log the right messages.
Oh, how did I miss it? It should be `err` obviously.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8839856 [details]
Bug 1341571 - 'ex' is not defined in TelemetryModules.jsm.

https://reviewboard.mozilla.org/r/114448/#review115882

Thanks for fixing that!
Attachment #8839856 - Flags: review?(alessio.placitelli) → review+

Comment 5

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c63fdfb7d873
'ex' is not defined in TelemetryModules.jsm. r=Dexter

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c63fdfb7d873
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.