Closed Bug 1341586 Opened 7 years ago Closed 7 years ago

Wrong replacement in context menu attribute strings

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: stef, Assigned: djmdeveloper060796)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch bug1341586.patch (obsolete) — Splinter Review
Removed quotes from context menu item label
Attachment #8839953 - Flags: review?(gl)
Hi stef,

I am trying to figure out why this is an issue. It seems the original intent was to always surround the value that would be edit, copy, and remove with quotations for better clarity.
Flags: needinfo?(splewako)
Perhaps your intention is to have the quotations inside the inspector.properties file instead of replacing the value with a value with quotation?
(In reply to Gabriel Luong [:gl][1 biz day review guarantee] (ΦωΦ) from comment #3)
> Perhaps your intention is to have the quotations inside the
> inspector.properties file instead of replacing the value with a value with
> quotation?
Yes, quotes get also localized.
Hi Deepjyoti,

We actually want to move the quotations inside the inspector.properties file
Assignee: nobody → djmdeveloper060796
Status: NEW → ASSIGNED
Flags: needinfo?(splewako)
Comment on attachment 8839953 [details] [diff] [review]
bug1341586.patch

This is correct. We also need to make the changes in inspector.properties
Attachment #8839953 - Flags: review?(gl)
Attached patch bug1341586.patchSplinter Review
Included quotations in properties file
Attachment #8840282 - Flags: review?(gl)
Attachment #8839953 - Attachment is obsolete: true
Comment on attachment 8840282 [details] [diff] [review]
bug1341586.patch

Review of attachment 8840282 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks again for the patch Deepjyoti.
Attachment #8840282 - Flags: review?(gl) → review+
I will push this manually when the tree reopens.
Flags: needinfo?(gl)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d5d1dfa8696
Fix localization of Inspector's attribute context menu by adding quotations to the values. r=gl
Flags: needinfo?(gl)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9faa310d3f
Fix localization of Inspector's attribute context menu by adding quotations to the values: Fix quote characters. r=test-fix on a CLOSED TREE
Firefox only uses opening and closing quotation marks, so I had to push that follow-up.
https://hg.mozilla.org/mozilla-central/rev/6d5d1dfa8696
https://hg.mozilla.org/mozilla-central/rev/5f9faa310d3f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I have reproduced this bug on Firefox nightly according to (2017-02-22)

Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

Tested OS-- Windows7 32bit
[testday-20170428]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.