1341586 - Wrong replacement in context menu attribute strings

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Stefan Plewako [:stef]]

https://hg.mozilla.org/mozilla-central/annotate/80e5378cc1c8/devtools/client/locales/en-US/inspector.properties#l110
https://hg.mozilla.org/mozilla-central/annotate/80e5378cc1c8/devtools/client/locales/en-US/inspector.properties#l117
https://hg.mozilla.org/mozilla-central/annotate/80e5378cc1c8/devtools/client/locales/en-US/inspector.properties#l124

%S in inspectorEditAttribute.label, inspectorRemoveAttribute.label and inspectorCopyAttributeValue.label are incorrectly replaced by quoted values (as "value") but raw values should be used (without quotes).

Comment 1

[Deepjyoti Mondal]

Attachment: bug1341586.patch

Removed quotes from context menu item label

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Hi stef,

I am trying to figure out why this is an issue. It seems the original intent was to always surround the value that would be edit, copy, and remove with quotations for better clarity.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Perhaps your intention is to have the quotations inside the inspector.properties file instead of replacing the value with a value with quotation?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Gabriel Luong [:gl][1 biz day review guarantee] (ΦωΦ) from comment #3)
> Perhaps your intention is to have the quotations inside the
> inspector.properties file instead of replacing the value with a value with
> quotation?
Yes, quotes get also localized.

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Hi Deepjyoti,

We actually want to move the quotations inside the inspector.properties file

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8839953 [details] [diff] [review]
bug1341586.patch

This is correct. We also need to make the changes in inspector.properties

Comment 7

[Deepjyoti Mondal]

Attachment: bug1341586.patch

Included quotations in properties file

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8840282 [details] [diff] [review]
bug1341586.patch

Review of attachment 8840282 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks again for the patch Deepjyoti.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

I will push this manually when the tree reopens.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d5d1dfa8696
Fix localization of Inspector's attribute context menu by adding quotations to the values. r=gl

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9faa310d3f
Fix localization of Inspector's attribute context menu by adding quotations to the values: Fix quote characters. r=test-fix on a CLOSED TREE

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox only uses opening and closing quotation marks, so I had to push that follow-up.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d5d1dfa8696
https://hg.mozilla.org/mozilla-central/rev/5f9faa310d3f

Comment 14

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox nightly according to (2017-02-22)

Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

Tested OS-- Windows7 32bit
[testday-20170428]