Wrong replacement in context menu attribute strings

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: stef, Assigned: Deepjyoti Mondal)

Tracking

unspecified
Firefox 54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 months ago
https://hg.mozilla.org/mozilla-central/annotate/80e5378cc1c8/devtools/client/locales/en-US/inspector.properties#l110
https://hg.mozilla.org/mozilla-central/annotate/80e5378cc1c8/devtools/client/locales/en-US/inspector.properties#l117
https://hg.mozilla.org/mozilla-central/annotate/80e5378cc1c8/devtools/client/locales/en-US/inspector.properties#l124

%S in inspectorEditAttribute.label, inspectorRemoveAttribute.label and inspectorCopyAttributeValue.label are incorrectly replaced by quoted values (as "value") but raw values should be used (without quotes).
(Assignee)

Comment 1

4 months ago
Created attachment 8839953 [details] [diff] [review]
bug1341586.patch

Removed quotes from context menu item label
Attachment #8839953 - Flags: review?(gl)
Hi stef,

I am trying to figure out why this is an issue. It seems the original intent was to always surround the value that would be edit, copy, and remove with quotations for better clarity.

Updated

4 months ago
Flags: needinfo?(splewako)
Perhaps your intention is to have the quotations inside the inspector.properties file instead of replacing the value with a value with quotation?
(In reply to Gabriel Luong [:gl][1 biz day review guarantee] (ΦωΦ) from comment #3)
> Perhaps your intention is to have the quotations inside the
> inspector.properties file instead of replacing the value with a value with
> quotation?
Yes, quotes get also localized.
Hi Deepjyoti,

We actually want to move the quotations inside the inspector.properties file
Assignee: nobody → djmdeveloper060796
Status: NEW → ASSIGNED
Flags: needinfo?(splewako)
Comment on attachment 8839953 [details] [diff] [review]
bug1341586.patch

This is correct. We also need to make the changes in inspector.properties
Attachment #8839953 - Flags: review?(gl)
(Assignee)

Comment 7

4 months ago
Created attachment 8840282 [details] [diff] [review]
bug1341586.patch

Included quotations in properties file
Attachment #8840282 - Flags: review?(gl)

Updated

4 months ago
Attachment #8839953 - Attachment is obsolete: true
Comment on attachment 8840282 [details] [diff] [review]
bug1341586.patch

Review of attachment 8840282 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks again for the patch Deepjyoti.
Attachment #8840282 - Flags: review?(gl) → review+
I will push this manually when the tree reopens.
Flags: needinfo?(gl)

Comment 10

4 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d5d1dfa8696
Fix localization of Inspector's attribute context menu by adding quotations to the values. r=gl

Updated

4 months ago
Flags: needinfo?(gl)

Comment 11

4 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9faa310d3f
Fix localization of Inspector's attribute context menu by adding quotations to the values: Fix quote characters. r=test-fix on a CLOSED TREE
Firefox only uses opening and closing quotation marks, so I had to push that follow-up.

Comment 13

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6d5d1dfa8696
https://hg.mozilla.org/mozilla-central/rev/5f9faa310d3f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I have reproduced this bug on Firefox nightly according to (2017-02-22)

Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

Tested OS-- Windows7 32bit
[testday-20170428]
You need to log in before you can comment on or make changes to this bug.