1341609 - Revoked blob URL should not cause XMLHttpRequest's open() to throw

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Anne (:annevk)]

Test: http://w3c-test.org/FileAPI/blob/Blob-XHR-revoke.html. In particular we should fail in the network stack instead, with a network error.

Related discussion: https://github.com/whatwg/xhr/issues/79.

Comment 1

[Andrew Overholt [:overholt]]

baku, will this be hard to change? Is there a past-Gecko-compat risk?

Comment 2

[Thomas Wisniewski]

We actually seem to be doing the right thing, except that we end up throwing the network error in send() rather than triggering an onerror (for async requests). I'll create a patch to correct that behavior.

Comment 3

[Thomas Wisniewski]

Attachment: Bug 1341609 - Don't throw on async XHR send() failures when open() created no channel;

Review commit: https://reviewboard.mozilla.org/r/184824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184824/

Comment 4

[Thomas Wisniewski]

I've just attached a patch which makes the async case trigger an onerror instead of throwing an exception. It seems to pass try (there are a couple of intermittents there which worried me at first, but seem unrelated): https://treeherder.mozilla.org/#/jobs?repo=try&revision=9564b70ab1d1a95e52e638a5ef13c7e6b8c80034

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8913482 [details]
Bug 1341609 - Don't throw on async XHR send() failures when open() created no channel;

https://reviewboard.mozilla.org/r/184824/#review190050

::: dom/xhr/XMLHttpRequestMainThread.cpp:2936
(Diff revision 1)
>      return;
>    }
>  }
>  
>  nsresult
> +XMLHttpRequestMainThread::MaybeSilentSendFailure(nsresult aRv) {

{ in a new line

Comment 6

[Thomas Wisniewski]

Comment on attachment 8913482 [details]
Bug 1341609 - Don't throw on async XHR send() failures when open() created no channel;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184824/diff/1-2/

Comment 7

[Thomas Wisniewski]

Review comments addressed, requesting checkin.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36eab49a7d10
Don't throw on async XHR send() failures when open() created no channel; r=baku

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/36eab49a7d10