Closed Bug 1341680 Opened 3 years ago Closed 3 years ago

this.layoutInspector is undefined when opening inspector

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STRs:
- enable layout panel in devtools config
- open inspector, with any other panel than the layout panel selected by default

=> Error is logged
> TypeError: this.layoutInspector is undefined: onSidebarSelect@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/layout/layout.js:451:7
> emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/event-emitter.js:191:13
> handleSelectionChange@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/toolsidebar.js:234:5
> select/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/components/tabs/tabbar.js:139:9
> notifyAll@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:842:9
> close@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:16630:5
> closeAll@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:19101:11
> perform@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:19048:11
> perform@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:16660:12
> flushBatchedUpdates@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:1
Summary: this.layoutInspector is unefined when opening inspector → this.layoutInspector is undefined when opening inspector
Flags: qe-verify-
Comment on attachment 8839998 [details]
Bug 1341680 - wait for layoutInspector to be initialized before attaching events;

https://reviewboard.mozilla.org/r/114556/#review116176
Attachment #8839998 - Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/882622ce817e
wait for layoutInspector to be initialized before attaching events;r=gl
https://hg.mozilla.org/mozilla-central/rev/882622ce817e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I have reproduced this bug with Firefox nightly 54.0a1 (build id:20170222030329)on
windows 7(64 bit)

I have verified this bug as fixed with Firefox beta 54.0b3 (build id:20170427091925)
User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0

[testday-20170428]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.