this.layoutInspector is undefined when opening inspector

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Inspector
P3
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 54
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
STRs:
- enable layout panel in devtools config
- open inspector, with any other panel than the layout panel selected by default

=> Error is logged
> TypeError: this.layoutInspector is undefined: onSidebarSelect@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/layout/layout.js:451:7
> emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/event-emitter.js:191:13
> handleSelectionChange@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/toolsidebar.js:234:5
> select/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/components/tabs/tabbar.js:139:9
> notifyAll@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:842:9
> close@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:16630:5
> closeAll@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:19101:11
> perform@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:19048:11
> perform@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:16660:12
> flushBatchedUpdates@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:1
Summary: this.layoutInspector is unefined when opening inspector → this.layoutInspector is undefined when opening inspector
Comment hidden (mozreview-request)

Updated

5 months ago
Flags: qe-verify-

Comment 2

5 months ago
mozreview-review
Comment on attachment 8839998 [details]
Bug 1341680 - wait for layoutInspector to be initialized before attaching events;

https://reviewboard.mozilla.org/r/114556/#review116176
Attachment #8839998 - Flags: review?(gl) → review+

Comment 3

5 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/882622ce817e
wait for layoutInspector to be initialized before attaching events;r=gl

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/882622ce817e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 5

3 months ago
I have reproduced this bug with Firefox nightly 54.0a1 (build id:20170222030329)on
windows 7(64 bit)

I have verified this bug as fixed with Firefox beta 54.0b3 (build id:20170427091925)
User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0

[testday-20170428]
You need to log in before you can comment on or make changes to this bug.