Closed
Bug 1341690
Opened 7 years ago
Closed 7 years ago
stylo: background-image doesn't work in inline style
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: manishearth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is what causes the really-big-background.html test failure. Probably relevant error message: WARN:style::values::specified::url: stylo: skipping declaration without ParserContextExtraData
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → manishearth
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•7 years ago
|
||
Hm, this test still fails. Wat.
Assignee | ||
Comment 6•7 years ago
|
||
Ah, I'd missed ParseStyleAttribute in my other patch. Fixing.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8846191 [details] Bug 1341690 - stylo: Make URLs work in inline style; https://reviewboard.mozilla.org/r/119296/#review121220 r=me with that. ::: layout/style/nsDOMCSSDeclaration.cpp:135 (Diff revision 3) > mozAutoDocConditionalContentUpdateBatch autoUpdate(DocToUpdate(), true); > > RefPtr<DeclarationBlock> newdecl; > if (olddecl->IsServo()) { > - newdecl = ServoDeclarationBlock::FromCssText(aCssText); > + GeckoParserExtraData data(env.mBaseURI, env.mSheetURI, env.mPrincipal); > + nsCString baseString; Let's move this to `FromCSSText`, where we already have the base uri in `GeckoParserExtraData` instead of duplicating it twice.
Attachment #8846191 -
Flags: review?(emilio+bugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
Servo at https://github.com/servo/servo/pull/15915
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•7 years ago
|
||
Yep, just need to autoland this, but that's blocked on VCS sync waking up
Comment 15•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 15ad85dc898c -d e18199b999a3: rebasing 381624:15ad85dc898c "Bug 1341690 - stylo: Make URLs work in inline style; r=emilio" (tip) merging dom/base/nsAttrValue.cpp merging layout/style/ServoBindingList.h merging layout/style/test/stylo-failures.md warning: conflicts while merging layout/style/test/stylo-failures.md! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment 16•7 years ago
|
||
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8949490f91a7 stylo: Make URLs work in inline style; r=emilio
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8949490f91a7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
status-firefox54:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•