1341705 - stylo: reenable the "289480.html#top" reftest

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It fails to load under stylo for some reason.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The reason it fails is that loading "289480.html#top" when it's already loaded does a _scroll_, not a load.

So maybe we want to rewrite it as:

== 289480.html#top 289480-ref.html
== 289480-ref.html 289480-ref.html

or so to make sure it's all good.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Reenable some stylo tests that involve urls with anchors

MozReview-Commit-ID: KYQTaW7WZOS

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8844590 [details] [diff] [review]
Reenable some stylo tests that involve urls with anchors

Review of attachment 8844590 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/bugs/reftest-stylo.list
@@ +306,5 @@
>  == 283686-2.html 283686-2.html
>  == 283686-3.html 283686-3.html
>  fails == 289384-1.xhtml 289384-1.xhtml
> +fails == 289480.html#top 289480-ref.html
> +fails == 289480-ref.html 289480-ref.html

Any reason to use this two step comparison for this test but not the others?  If not, may as well use the same technique (either the two step, or just compare to the -ref file directly) for all of them.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Any reason to use this two step comparison for this test but not the others?

Yes.  For the others the ref also has an anchor.  So the two-step comparison would look like this:

  == foo#bar foo-ref#bar
  == foo-ref#bar foo-ref#bar

which would fail for the same exact reason.  I also considered this:

  == foo#bar foo-ref#bar
  == foo-ref#bar foo#bar

but then I think the first load of the second line would not happen....

I could try to explicitly use test-pref and ref-pref to reverse which one is servo and which one is gecko, maybe, but that seemed pretty painful.

Comment 5

[Cameron McCormack (:heycam)]

OK, the patch as it is is fine then.  Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7232bdee90
Reenable some stylo tests that involve urls with anchors.  r=heycam

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8d7232bdee90