Closed
Bug 1341705
Opened 7 years ago
Closed 7 years ago
stylo: reenable the "289480.html#top" reftest
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.05 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
It fails to load under stylo for some reason.
Assignee | ||
Comment 1•7 years ago
|
||
The reason it fails is that loading "289480.html#top" when it's already loaded does a _scroll_, not a load. So maybe we want to rewrite it as: == 289480.html#top 289480-ref.html == 289480-ref.html 289480-ref.html or so to make sure it's all good.
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: KYQTaW7WZOS
Attachment #8844590 -
Flags: review?(cam)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
Comment on attachment 8844590 [details] [diff] [review] Reenable some stylo tests that involve urls with anchors Review of attachment 8844590 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/reftests/bugs/reftest-stylo.list @@ +306,5 @@ > == 283686-2.html 283686-2.html > == 283686-3.html 283686-3.html > fails == 289384-1.xhtml 289384-1.xhtml > +fails == 289480.html#top 289480-ref.html > +fails == 289480-ref.html 289480-ref.html Any reason to use this two step comparison for this test but not the others? If not, may as well use the same technique (either the two step, or just compare to the -ref file directly) for all of them.
Attachment #8844590 -
Flags: review?(cam) → review+
Assignee | ||
Comment 4•7 years ago
|
||
> Any reason to use this two step comparison for this test but not the others?
Yes. For the others the ref also has an anchor. So the two-step comparison would look like this:
== foo#bar foo-ref#bar
== foo-ref#bar foo-ref#bar
which would fail for the same exact reason. I also considered this:
== foo#bar foo-ref#bar
== foo-ref#bar foo#bar
but then I think the first load of the second line would not happen....
I could try to explicitly use test-pref and ref-pref to reverse which one is servo and which one is gecko, maybe, but that seemed pretty painful.
Comment 5•7 years ago
|
||
OK, the patch as it is is fine then. Thanks!
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7232bdee90 Reenable some stylo tests that involve urls with anchors. r=heycam
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d7232bdee90
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•