Closed Bug 1341716 Opened 8 years ago Closed 3 years ago

Walking the stack incorrectly in the profiler makes us show a call to Preferences::GetBool from Exception::Initialize

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE
Project Flags:
Performance Impact low

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

(Keywords: perf)

See this profile: https://perfht.ml/2l8Rq1f There is some inlining involved here...
Blocks: 1334263
Priority: -- → P1
John is going to help this out, thanks!
Assignee: nobody → jdai
After I traced into the profile, I found there are two places use Preferences::GetBool(). One is HTMLInputElement::ValueAsDateEnabled() which has been handled by bug 1341376, another is HTMLInputElement::SetFilesOrDirectories()[1]. However, I didn't find calls to Preferences::GetBool() in Exception::Initializa() call stack. [1] http://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#3047-3062
Hi :Ehsan, Could you give me a more detailed STR? I couldn't hit the Exception::Initialize() in debugger. Thank you.
Flags: needinfo?(ehsan)
Sorry I don't have any STRs besides the profile that I saw in comment 0. If you didn't hit this in the debugger that means that we're walking the stack incorrectly. Moving the bug to Gecko Profiler.
Assignee: jdai → nobody
Component: DOM → Gecko Profiler
Flags: needinfo?(ehsan)
Summary: Stop calling Preferences::GetBool from Exception::Initialize → Walking the stack incorrectly in the profiler makes us show a call to Preferences::GetBool from Exception::Initialize
Priority: P1 → --
Whiteboard: [qf:p5]
Keywords: perf
Performance Impact: --- → P3
Whiteboard: [qf:p5]

Too old to be acted upon, sorry. Please re-open/re-file if you can capture new profiles showing this issue.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.