1341716 - Walking the stack incorrectly in the profiler makes us show a call to Preferences::GetBool from Exception::Initialize

Status: RESOLVED INCOMPLETE

(Core :: Gecko Profiler, defect)

Description

[(no longer active)]

See this profile: https://perfht.ml/2l8Rq1f

There is some inlining involved here...

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

John is going to help this out, thanks!

Comment 2

[John Dai[:jdai]]

After I traced into the profile, I found there are two places use Preferences::GetBool(). 
One is HTMLInputElement::ValueAsDateEnabled() which has been handled by bug 1341376, another is HTMLInputElement::SetFilesOrDirectories()[1].

However, I didn't find calls to Preferences::GetBool() in Exception::Initializa() call stack.

[1] http://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#3047-3062

Comment 3

[John Dai[:jdai]]

Hi :Ehsan,
Could you give me a more detailed STR? I couldn't hit the Exception::Initialize() in debugger. Thank you.

Comment 4

[(no longer active)]

Sorry I don't have any STRs besides the profile that I saw in comment 0.  If you didn't hit this in the debugger that means that we're walking the stack incorrectly.  Moving the bug to Gecko Profiler.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Too old to be acted upon, sorry. Please re-open/re-file if you can capture new profiles showing this issue.