Walking the stack incorrectly in the profiler makes us show a call to Preferences::GetBool from Exception::Initialize

NEW
Unassigned

Status

()

2 years ago
a year ago

People

(Reporter: Ehsan, Unassigned)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qf:p5])

(Reporter)

Description

2 years ago
See this profile: https://perfht.ml/2l8Rq1f

There is some inlining involved here...
(Reporter)

Updated

2 years ago
Blocks: 1334263

Updated

2 years ago
Priority: -- → P1
John is going to help this out, thanks!
Assignee: nobody → jdai

Comment 2

2 years ago
After I traced into the profile, I found there are two places use Preferences::GetBool(). 
One is HTMLInputElement::ValueAsDateEnabled() which has been handled by bug 1341376, another is HTMLInputElement::SetFilesOrDirectories()[1].

However, I didn't find calls to Preferences::GetBool() in Exception::Initializa() call stack.

[1] http://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#3047-3062

Comment 3

2 years ago
Hi :Ehsan,
Could you give me a more detailed STR? I couldn't hit the Exception::Initialize() in debugger. Thank you.
Flags: needinfo?(ehsan)
(Reporter)

Comment 4

2 years ago
Sorry I don't have any STRs besides the profile that I saw in comment 0.  If you didn't hit this in the debugger that means that we're walking the stack incorrectly.  Moving the bug to Gecko Profiler.
Assignee: jdai → nobody
Component: DOM → Gecko Profiler
Flags: needinfo?(ehsan)
Summary: Stop calling Preferences::GetBool from Exception::Initialize → Walking the stack incorrectly in the profiler makes us show a call to Preferences::GetBool from Exception::Initialize

Updated

2 years ago
Priority: P1 → --
Whiteboard: [qf:p5]
You need to log in before you can comment on or make changes to this bug.