Closed Bug 1341728 Opened 3 years ago Closed 3 years ago
stylo: Need to support the "clip" property
Simple testcase: data:text/html,<div style="clip: rect(0, 0, 0, 0)"><script>alert(document.querySelector("div").style.clip);</script> This does not work right. I'm not sure whether the problem is in servo or the glue code.
Looks like the property glue doesn't support it yet: http://searchfox.org/mozilla-central/rev/39e4b25a076c59d2e7820297d62319f167871449/servo/components/style/properties/longhand/effects.mako.rs#84
I can work on the glue part.
(In reply to Nazım Can Altınova [:canaltinova] from comment #2) > I can work on the glue part. Awesome, thanks!
Opened a PR in servo: https://github.com/servo/servo/pull/15710
Assignee: nobody → canaltinova
PR is merged. Clip property should work now.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d1ac7cfa737c test expectation adjustments, since servo now supports clip. r=bzbarsky
Yay, passing tests. Thank you!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/6cea4e8a9158 more test expectation adjustments, for mochitests now. r=bzbarsky
You need to log in before you can comment on or make changes to this bug.