Closed
Bug 1341728
Opened 8 years ago
Closed 8 years ago
stylo: Need to support the "clip" property
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | affected |
People
(Reporter: bzbarsky, Assigned: canova)
References
(Blocks 1 open bug)
Details
Simple testcase:
data:text/html,<div style="clip: rect(0, 0, 0, 0)"><script>alert(document.querySelector("div").style.clip);</script>
This does not work right. I'm not sure whether the problem is in servo or the glue code.
|
||
Comment 1•8 years ago
|
||
Looks like the property glue doesn't support it yet:
http://searchfox.org/mozilla-central/rev/39e4b25a076c59d2e7820297d62319f167871449/servo/components/style/properties/longhand/effects.mako.rs#84
|
Assignee | |
Comment 2•8 years ago
|
||
I can work on the glue part.
|
|
||
Comment 3•8 years ago
|
||
(In reply to Nazım Can Altınova [:canaltinova] from comment #2)
> I can work on the glue part.
Awesome, thanks!
|
|
Assignee | |
Comment 4•8 years ago
|
||
Opened a PR in servo: https://github.com/servo/servo/pull/15710
Assignee: nobody → canaltinova
|
|
Assignee | |
Comment 5•8 years ago
|
||
PR is merged. Clip property should work now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1ac7cfa737c
test expectation adjustments, since servo now supports clip. r=bzbarsky
|
Reporter | |
Comment 7•8 years ago
|
||
Yay, passing tests. Thank you!
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cea4e8a9158
more test expectation adjustments, for mochitests now. r=bzbarsky
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•