Closed
Bug 1341734
Opened 7 years ago
Closed 7 years ago
remove disableSHA1rollout add-on from the tree
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: keeler, Assigned: keeler)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Felipe
:
review+
jcj
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
Now that bug 1330043 is moving up the trains (which disables sha-1 by default via a preference), we don't need the add-on in the tree.
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8840117 -
Flags: review?(felipc) → review+
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8840117 [details] bug 1341734 - remove the disableSHA1rollout addon https://reviewboard.mozilla.org/r/114642/#review116172 You were a good addon, disableSHA1rollout.
Attachment #8840117 -
Flags: review?(jjones) → review+
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4799fdd23295 remove the disableSHA1rollout addon r=jcj
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4799fdd23295
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 5•7 years ago
|
||
Comment on attachment 8840117 [details] bug 1341734 - remove the disableSHA1rollout addon Since Bug 1330043 flipped this pref in Beta52 [1], the add-on is no longer needed there, or in Aurora53. To avoid conflicts, let's delete this from those branches, too. Approval Request Comment [Feature/Bug causing the regression]: Bug 1330043 [User impact if declined]: No user impact, so it should be safe (if unclean) to leave in place. [Is this code covered by automated tests?]: N/A [Has the fix been verified in Nightly?]: N/A [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: It's only removal of a system add-on. [String changes made/needed]: None. [1] https://hg.mozilla.org/releases/mozilla-beta/rev/3aaf82595ea5
Attachment #8840117 -
Flags: approval-mozilla-beta?
Attachment #8840117 -
Flags: approval-mozilla-aurora?
Comment 6•7 years ago
|
||
Comment on attachment 8840117 [details] bug 1341734 - remove the disableSHA1rollout addon Let's do it.
Attachment #8840117 -
Flags: approval-mozilla-beta?
Attachment #8840117 -
Flags: approval-mozilla-beta+
Attachment #8840117 -
Flags: approval-mozilla-aurora?
Attachment #8840117 -
Flags: approval-mozilla-aurora+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/0e612af21502
status-firefox53:
--- → fixed
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/8a654cb6a61e
status-firefox52:
--- → fixed
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/8a654cb6a61e
status-firefox-esr52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•