1341734 - remove disableSHA1rollout add-on from the tree

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Now that bug 1330043 is moving up the trains (which disables sha-1 by default via a preference), we don't need the add-on in the tree.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1341734 - remove the disableSHA1rollout addon

Review commit: https://reviewboard.mozilla.org/r/114642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114642/

Comment 2

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8840117 [details]
bug 1341734 - remove the disableSHA1rollout addon

https://reviewboard.mozilla.org/r/114642/#review116172

You were a good addon, disableSHA1rollout.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4799fdd23295
remove the disableSHA1rollout addon r=jcj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4799fdd23295

Comment 5

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8840117 [details]
bug 1341734 - remove the disableSHA1rollout addon

Since Bug 1330043 flipped this pref in Beta52 [1], the add-on is no longer needed there, or in Aurora53. To avoid conflicts, let's delete this from those branches, too.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1330043
[User impact if declined]: No user impact, so it should be safe (if unclean) to leave in place.
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's only removal of a system add-on.
[String changes made/needed]: None.

[1] https://hg.mozilla.org/releases/mozilla-beta/rev/3aaf82595ea5

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8840117 [details]
bug 1341734 - remove the disableSHA1rollout addon

Let's do it.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0e612af21502

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a654cb6a61e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/8a654cb6a61e