Closed
Bug 1341739
Opened 7 years ago
Closed 7 years ago
stylo: need support for :valid/:invalid/:-moz-ui-valid pseudo-classes
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: canova)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
This does not seem to be supported.
|
||
Comment 1•7 years ago
|
||
These are also "state" pseudo-classes, so same strategy as https://bugzilla.mozilla.org/show_bug.cgi?id=1341642#c1
|
||
Updated•7 years ago
|
Blocks: stylo-syntax
|
|
||
Updated•7 years ago
|
Assignee: nobody → canaltinova
Priority: -- → P1
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847632 [details] Bug 1341739 - Part 1: Stylo: Add placeholder-shown and target pseudo-classes to pseudo_class_list macro https://reviewboard.mozilla.org/r/120574/#review122690 This seem to be a Servo-side only change. You may not want to give it a part number since it's not going to land on m-c as is.
Attachment #8847632 -
Flags: review?(xidorn+moz) → review+
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847633 [details] Bug 1341739 - Stylo: Add support for :valid/:invalid/:-moz-ui-valid pseudo-classes https://reviewboard.mozilla.org/r/120576/#review122692
Attachment #8847633 -
Flags: review?(xidorn+moz) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8847632 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•7 years ago
|
||
Stripped the Servo side and opened a PR here: https://github.com/servo/servo/pull/15983
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b32b0a3d8a60 Stylo: Add support for :valid/:invalid/:-moz-ui-valid pseudo-classes r=xidorn
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1276d4ba1ebc Update test expectations. r=me
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b32b0a3d8a60 https://hg.mozilla.org/mozilla-central/rev/1276d4ba1ebc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
status-firefox54:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•