stylo: need support for :valid/:invalid/:-moz-ui-valid pseudo-classes

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: bz, Assigned: canaltinova)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 affected, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

This does not seem to be supported.
These are also "state" pseudo-classes, so same strategy as https://bugzilla.mozilla.org/show_bug.cgi?id=1341642#c1
Blocks: 1345200
Assignee: nobody → canaltinova
Priority: -- → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8847632 [details]
Bug 1341739 - Part 1: Stylo: Add placeholder-shown and target pseudo-classes to pseudo_class_list macro

https://reviewboard.mozilla.org/r/120574/#review122690

This seem to be a Servo-side only change. You may not want to give it a part number since it's not going to land on m-c as is.
Attachment #8847632 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8847633 [details]
Bug 1341739 - Stylo: Add support for :valid/:invalid/:-moz-ui-valid pseudo-classes

https://reviewboard.mozilla.org/r/120576/#review122692
Attachment #8847633 - Flags: review?(xidorn+moz) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

a month ago
Attachment #8847632 - Attachment is obsolete: true
(Assignee)

Comment 7

a month ago
Stripped the Servo side and opened a PR here: https://github.com/servo/servo/pull/15983

Comment 8

a month ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b32b0a3d8a60
Stylo: Add support for :valid/:invalid/:-moz-ui-valid pseudo-classes r=xidorn

Comment 9

a month ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1276d4ba1ebc
Update test expectations. r=me

Comment 10

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b32b0a3d8a60
https://hg.mozilla.org/mozilla-central/rev/1276d4ba1ebc
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.