1341778 - Add an --autoland option to "hg push review"

Status: RESOLVED INVALID

(MozReview Graveyard :: Integration: Mercurial, defect)

Description

[Botond Ballo [:botond]]

Often reviewers will give you an "r+ with comments", where they ask you to make some changes, but do not need to to see the patch again after you make the changes.

In such cases, after addressing the review comments there are two possible workflows:

  1) Land directly on mozilla-inbound from the command line

  2) Push a new review request (which carries the r+), and then autoland it

(1) has the advantage of staying entirely on the command-line, but the disadvantage of having to pull the m-i tip and rebase the patch series onto it manually. Also, we're told (1) is discouraged because the ability to land directly will eventually go away.

To get the best of both worlds, I'd like to propose that an "--autoland" command-line option be added to "hg push review", which would autoland the patch series after submitting it to MozReview, thus allowing you to stay on the command-line.

Naturally, "--autoland" should only work if you already have r+ for all the patches in the series. If you don't, the new patch series should still be submitted to MozReview, but you should get a message saying that you can't autoland yet.

Comment 1

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.