Closed Bug 1341815 Opened 3 years ago Closed 3 years ago

stylo: figure out why pretty much all the meter and progress reftests fail

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox54 --- affected

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Stylo:blocked])

See layout/reftests/forms/progress/ and layout/reftests/forms/meter
Summary: stylo: figure out why pretty much all the meter an progress reftests fail → stylo: figure out why pretty much all the meter and progress reftests fail
Are they dynamic? If so it's probably because that stuff is nac-implemented, and we don't have bug 1331047 yet.
Depends on: 1331047
Hmm.  I don't think they _mean_ to be dynamic.  But for example http://searchfox.org/mozilla-central/source/layout/reftests/forms/progress/values.html has:

  <link rel='stylesheet' type='text/css' href='style.css'>
  <body>
    <progress value="1.0"></progress>

which will possibly render the <progress> the first time before the sheet loads...
Whiteboard: [Stylo:blocked]
Priority: -- → P2
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
I did a try with a tweak that HasAuthorSpecifiedRules() always returns false.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd3e30e1af59f5d25a6a3486c3896ffcaaadee5d&selectedJob=97076116

Rest of progress reftest failures passed.
Now I am convinced that this bug will also fixed by bug
Depends on: 1349651
As per Matt's try in bug 1349651 comment 6, all progress reftests passed there!
After bug 1349651, layout/reftests/forms/meter/max-height.html still fails. Oddly this passed in a Matt's try in bug 1349651 comment 6. Also the failure difference is gradient color inside meter element (see [1] for example). 

[1] https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/aayWFCZGR6ej2Q4olmU-zA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Rest of failures are:

layout/reftests/forms/meter/max-height.html (will be fixed by bug 136398, see a nox's try[1])
layout/reftests/forms/meter/default-style/default-style.html (willbe fixed by 1363986, see a nox's try[1])
layout/reftests/forms/meter/default-style/default-style-dyn.html (has been fixed bug 1364377 in autoland)

Great!
I will close this bug once those fixes landed in mozilla-central.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a594bfd11a892a3cfd9b9f05f062acabab90e2c
Assignee: hikezoe → nobody
Status: ASSIGNED → NEW
(In reply to Hiroyuki Ikezoe (:hiro) from comment #6)
> Rest of failures are:
> 
> layout/reftests/forms/meter/max-height.html (will be fixed by bug 136398,

Sorry, wrong bug. The correct one is bug 1363986.
Depends on: 1363986, 1364377
Now both of bugs have been closed.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.